From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbns3-0002JW-Rk for qemu-devel@nongnu.org; Tue, 15 Sep 2015 06:53:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zbnry-0004pX-Uz for qemu-devel@nongnu.org; Tue, 15 Sep 2015 06:53:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbnry-0004pS-Pj for qemu-devel@nongnu.org; Tue, 15 Sep 2015 06:53:50 -0400 Date: Tue, 15 Sep 2015 11:53:46 +0100 From: "Daniel P. Berrange" Message-ID: <20150915105346.GI23145@redhat.com> References: <1442253477-15422-1-git-send-email-armbru@redhat.com> <1442253477-15422-15-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1442253477-15422-15-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 14/26] qapi-visit: Rearrange code a bit Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Mon, Sep 14, 2015 at 07:57:45PM +0200, Markus Armbruster wrote: > Move gen_visit_decl() to a better place. Inline > generate_visit_struct_body(). > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > scripts/qapi-visit.py | 50 ++++++++++++++++++++------------------------------ > 1 file changed, 20 insertions(+), 30 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|