From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbnt9-0003EO-Rn for qemu-devel@nongnu.org; Tue, 15 Sep 2015 06:55:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zbnt7-00055J-4f for qemu-devel@nongnu.org; Tue, 15 Sep 2015 06:55:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zbnt6-00055F-W8 for qemu-devel@nongnu.org; Tue, 15 Sep 2015 06:55:01 -0400 Date: Tue, 15 Sep 2015 11:54:56 +0100 From: "Daniel P. Berrange" Message-ID: <20150915105456.GJ23145@redhat.com> References: <1442253477-15422-1-git-send-email-armbru@redhat.com> <1442253477-15422-16-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1442253477-15422-16-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 15/26] qapi-commands: Rearrange code Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Mon, Sep 14, 2015 at 07:57:46PM +0200, Markus Armbruster wrote: > Rename gen_marshal_input() to gen_marshal(), because the generated > function marshals both arguments and results. > > Rename gen_visitor_input_containers_decl() to gen_marshal_vars(), and > move the other variable declarations there, too. > > Rename gen_visitor_input_block() to gen_marshal_input_visit(), and > rearrange its code slightly. > > Rename gen_marshal_input_decl() to gen_marshal_proto(), because the > result isn't a full declaration, unlike gen_command_decl()'s. > > New gen_marshal_decl() actually returns a full declaration. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > scripts/qapi-commands.py | 87 ++++++++++++++++++++++-------------------------- > 1 file changed, 39 insertions(+), 48 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|