Re: [Qemu-devel] [PATCH v7 21/26] qapi: Introduce a first class 'any' type

["Daniel P. Berrange" <berrange@redhat.com>]

On Mon, Sep 14, 2015 at 07:57:52PM +0200, Markus Armbruster wrote:
> It's first class, because unlike '**', it actually works, i.e. doesn't
> require 'gen': false.
> 
> '**' will go away next.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  docs/qapi-code-gen.txt                             |  1 +
>  include/qapi/visitor-impl.h                        |  2 +
>  include/qapi/visitor.h                             |  1 +
>  qapi/qapi-dealloc-visitor.c                        |  9 ++++
>  qapi/qapi-visit-core.c                             |  6 +++
>  qapi/qmp-input-visitor.c                           | 11 +++++
>  qapi/qmp-output-visitor.c                          |  9 ++++
>  scripts/qapi-types.py                              |  1 +
>  scripts/qapi.py                                    |  9 ++--
>  tests/Makefile                                     |  3 +-
>  tests/qapi-schema/args-any.err                     |  1 +
>  .../{flat-union-base-star.exit => args-any.exit}   |  0
>  tests/qapi-schema/args-any.json                    |  2 +
>  .../{flat-union-base-star.out => args-any.out}     |  0
>  tests/qapi-schema/flat-union-base-any.err          |  1 +
>  tests/qapi-schema/flat-union-base-any.exit         |  1 +
>  ...ion-base-star.json => flat-union-base-any.json} |  2 +-
>  tests/qapi-schema/flat-union-base-any.out          |  0
>  tests/qapi-schema/flat-union-base-star.err         |  1 -
>  tests/qapi-schema/qapi-schema-test.json            |  5 +-
>  tests/qapi-schema/qapi-schema-test.out             |  9 +++-
>  tests/qapi-schema/type-bypass.out                  |  4 +-
>  tests/test-qmp-commands.c                          |  5 ++
>  tests/test-qmp-input-visitor.c                     | 45 ++++++++++++++++++
>  tests/test-qmp-output-visitor.c                    | 53 ++++++++++++++++++++++
>  25 files changed, 171 insertions(+), 10 deletions(-)
>  create mode 100644 tests/qapi-schema/args-any.err
>  rename tests/qapi-schema/{flat-union-base-star.exit => args-any.exit} (100%)
>  create mode 100644 tests/qapi-schema/args-any.json
>  rename tests/qapi-schema/{flat-union-base-star.out => args-any.out} (100%)
>  create mode 100644 tests/qapi-schema/flat-union-base-any.err
>  create mode 100644 tests/qapi-schema/flat-union-base-any.exit
>  rename tests/qapi-schema/{flat-union-base-star.json => flat-union-base-any.json} (95%)
>  create mode 100644 tests/qapi-schema/flat-union-base-any.out
>  delete mode 100644 tests/qapi-schema/flat-union-base-star.err


Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|