From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZboaD-0006FW-9B for qemu-devel@nongnu.org; Tue, 15 Sep 2015 07:39:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zboa9-0008PD-KO for qemu-devel@nongnu.org; Tue, 15 Sep 2015 07:39:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zboa9-0008P6-DD for qemu-devel@nongnu.org; Tue, 15 Sep 2015 07:39:29 -0400 Date: Tue, 15 Sep 2015 12:39:22 +0100 From: "Daniel P. Berrange" Message-ID: <20150915113922.GP23145@redhat.com> References: <1442253477-15422-1-git-send-email-armbru@redhat.com> <1442253477-15422-22-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1442253477-15422-22-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 21/26] qapi: Introduce a first class 'any' type Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Mon, Sep 14, 2015 at 07:57:52PM +0200, Markus Armbruster wrote: > It's first class, because unlike '**', it actually works, i.e. doesn't > require 'gen': false. > > '**' will go away next. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > docs/qapi-code-gen.txt | 1 + > include/qapi/visitor-impl.h | 2 + > include/qapi/visitor.h | 1 + > qapi/qapi-dealloc-visitor.c | 9 ++++ > qapi/qapi-visit-core.c | 6 +++ > qapi/qmp-input-visitor.c | 11 +++++ > qapi/qmp-output-visitor.c | 9 ++++ > scripts/qapi-types.py | 1 + > scripts/qapi.py | 9 ++-- > tests/Makefile | 3 +- > tests/qapi-schema/args-any.err | 1 + > .../{flat-union-base-star.exit => args-any.exit} | 0 > tests/qapi-schema/args-any.json | 2 + > .../{flat-union-base-star.out => args-any.out} | 0 > tests/qapi-schema/flat-union-base-any.err | 1 + > tests/qapi-schema/flat-union-base-any.exit | 1 + > ...ion-base-star.json => flat-union-base-any.json} | 2 +- > tests/qapi-schema/flat-union-base-any.out | 0 > tests/qapi-schema/flat-union-base-star.err | 1 - > tests/qapi-schema/qapi-schema-test.json | 5 +- > tests/qapi-schema/qapi-schema-test.out | 9 +++- > tests/qapi-schema/type-bypass.out | 4 +- > tests/test-qmp-commands.c | 5 ++ > tests/test-qmp-input-visitor.c | 45 ++++++++++++++++++ > tests/test-qmp-output-visitor.c | 53 ++++++++++++++++++++++ > 25 files changed, 171 insertions(+), 10 deletions(-) > create mode 100644 tests/qapi-schema/args-any.err > rename tests/qapi-schema/{flat-union-base-star.exit => args-any.exit} (100%) > create mode 100644 tests/qapi-schema/args-any.json > rename tests/qapi-schema/{flat-union-base-star.out => args-any.out} (100%) > create mode 100644 tests/qapi-schema/flat-union-base-any.err > create mode 100644 tests/qapi-schema/flat-union-base-any.exit > rename tests/qapi-schema/{flat-union-base-star.json => flat-union-base-any.json} (95%) > create mode 100644 tests/qapi-schema/flat-union-base-any.out > delete mode 100644 tests/qapi-schema/flat-union-base-star.err Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|