From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbodR-0000se-A0 for qemu-devel@nongnu.org; Tue, 15 Sep 2015 07:42:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbodN-0001Wu-KS for qemu-devel@nongnu.org; Tue, 15 Sep 2015 07:42:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbodN-0001Wk-G1 for qemu-devel@nongnu.org; Tue, 15 Sep 2015 07:42:49 -0400 Date: Tue, 15 Sep 2015 12:42:43 +0100 From: "Daniel P. Berrange" Message-ID: <20150915114243.GR23145@redhat.com> References: <1442253477-15422-1-git-send-email-armbru@redhat.com> <1442253477-15422-23-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1442253477-15422-23-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 22/26] qom: Don't use 'gen': false for qom-get, qom-set, object-add Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Mon, Sep 14, 2015 at 07:57:53PM +0200, Markus Armbruster wrote: > With the previous commit, the generated marshalers just work, and save > us a bit of handwritten code. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > include/monitor/monitor.h | 3 --- > qapi-schema.json | 9 +++------ > qmp-commands.hx | 6 +++--- > qmp.c | 21 +++++++-------------- > scripts/qapi.py | 1 + > 5 files changed, 14 insertions(+), 26 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|