From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38124)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <konrad.wilk@oracle.com>) id 1ZbqXw-0005Xv-JC
	for qemu-devel@nongnu.org; Tue, 15 Sep 2015 09:45:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <konrad.wilk@oracle.com>) id 1ZbqXt-0008GV-L8
	for qemu-devel@nongnu.org; Tue, 15 Sep 2015 09:45:20 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:32706)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <konrad.wilk@oracle.com>) id 1ZbqEt-0007Kv-9H
	for qemu-devel@nongnu.org; Tue, 15 Sep 2015 09:25:39 -0400
Date: Tue, 15 Sep 2015 09:25:31 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Message-ID: <20150915132531.GC9134@l.oracle.com>
References: <alpine.DEB.2.02.1509101751470.2672@kaball.uk.xensource.com>
	<1441905361-31967-21-git-send-email-stefano.stabellini@eu.citrix.com>
	<55F69ADF.40404@redhat.com>
	<alpine.DEB.2.02.1509151057580.2672@kaball.uk.xensource.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.02.1509151057580.2672@kaball.uk.xensource.com>
Subject: Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and
	data values.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, xen-devel@lists.xensource.com, qemu-devel@nongnu.org, peter.maydell@linaro.org

On Tue, Sep 15, 2015 at 11:07:02AM +0100, Stefano Stabellini wrote:
> CC Konrad
> 
> On Mon, 14 Sep 2015, Paolo Bonzini wrote:
> > On 10/09/2015 19:15, Stefano Stabellini wrote:
> > > +
> > > +        switch (reg->size) {
> > > +        case 1: rc = xen_host_pci_get_byte(&s->real_device, offset, (uint8_t *)&val);
> > 
> > A bit ugly, and it relies on the host being little endian.
> > 
> > > +                break;
> > > +        case 2: rc = xen_host_pci_get_word(&s->real_device, offset, (uint16_t *)&val);
> > 
> > Same here.
> 
> cpu_to_le32?
> 
> But in practice, Xen being little endian only, I doubt that xen_pt_config_init.c
> would actually work on be.
> 
> 
> > > +                break;
> > > +        case 4: rc = xen_host_pci_get_long(&s->real_device, offset, &val);
> > > +                break;
> > > +        default: assert(1);
> > 
> > This should be assert(0) or, better, abort().

OK. Stefano, do you want me to:

 1). Rebase the patches on top of your tag?
 2). Send an follow up patch to change this to abort()? (and wherever else I used
     assert(..)?
 3). Wait till Paolo is done going through the patchset and then revisit 1) or 2)?