Re: [Qemu-devel] [RFC PATCH] libcacard: move it to a standalone project

["Daniel P. Berrange" <berrange@redhat.com>]

On Tue, Sep 15, 2015 at 01:50:15PM +0200, Marc-André Lureau wrote:
> Hi
> 
> (added in CC people from the "libcacard: use the library?" thread)
> 
> On Thu, Sep 10, 2015 at 7:47 PM, Jeremy White <jwhite@codeweavers.com> wrote:
> > On 08/30/2015 06:29 AM, marcandre.lureau@redhat.com wrote:
> >> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >>
> >> As previously discussed in the thread "libcacard: use the library?",
> >> make libcacard a standalone library and use it if --enable-smartcard.
> >>
> >> I made the following repo out of a qemu filter-branch and added autofoo
> >> build-sys: https://github.com/elmarco/libcacard. Since the original qemu
> >> git tags are there, I think the first release version should be v2.5,
> >> but there is no need to follow the same versions as qemu later on.
> >>
> >> libcacard could use the same infrastructure as the qemu project (mailing
> >> list, git server, reviews etc). I have some experience with libcacard,
> >> and I would be willing to maintain it, however I don't expect to do
> >> more development with it in the near future.
> >>
> >> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > I have reviewed this patch, and the new libcacard module.  Modulo a few
> > minor nits (which Marc-André agreed to fix on irc), it all works well.
> > I think this is a sensible change and  I'm willing to help with
> > libcacard maintenance, if we were to establish it as a project.
> >
> > Reviewed-by: Jeremy White <jwhite@codeweavers.com>
> 
> In order to progress with this removal, I propose we move
> https://github.com/elmarco/libcacard master to git.qemu.org. Then make
> a 2.4.1 release (ie same as 2.4 but standalone), make a wiki page
> about libcacard etc. Then I can send a non-RFC patch to qemu, and we
> can keep maintaining libcacard within qemu project. I have pending
> patches in the next tree that I can send on the ML for review etc.
> 
> What do you think?

I have looked through the new libcacard git repository you created
from QEMU history, and reviewed the extra patches you added on top
for the build system and it all looks sane to me. So this this a

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

for both the new GIT repo and also your proposed patch to switch
QEMU to use the new lib.

I agree that it could make sense to host libcacard.git on git.qemu.org
if we're going to continue to use qemu-devel and a QEMU-like workflow,
but equally don't see any problem with it being a totally standalone
project with its own infra & practices.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|