qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: jasowang@redhat.com, qemu-devel@nongnu.org, changchun.ouyang@intel.com
Subject: Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support
Date: Wed, 16 Sep 2015 16:23:08 +0800	[thread overview]
Message-ID: <20150916082308.GH2339@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20150916110625-mutt-send-email-mst@redhat.com>

On Wed, Sep 16, 2015 at 11:10:35AM +0300, Michael S. Tsirkin wrote:
> On Wed, Sep 16, 2015 at 10:06:56AM +0800, Yuanhan Liu wrote:
> > If not, I'd like to put them into the commit log, as putting it
> > outside the commit log gives unnecessary extra burden to patch
> > author when he need update several version change information
> > in a patch set: he has to format the patch set first, and add
> > them one by one by editing those patches.
> 
> I personally just describe the changes in the cover letter.

I did that as well. I just thought metioning them inside the patch
again will make it clear for you to review.

	--yliu
> 
> In fact, while not a lot of people do this, git-backport-diff
> (from https://github.com/codyprime/git-scripts.git)
> is a handy tool to show which patches changed since the
> previous version, and it only works if the change log
> is in the cover letter.
> 
> Or you can stick --- in the commit log as you have found out -
> but that depends on the patch author being careful to log
> all edits.
> -- 
> MST

  reply	other threads:[~2015-09-16  8:22 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15  7:10 [Qemu-devel] [PATCH 0/7 v9] vhost-user multiple queue support Yuanhan Liu
2015-09-15  7:10 ` [Qemu-devel] [PATCH 1/7] vhost-user: use VHOST_USER_XXX macro for switch statement Yuanhan Liu
2015-09-15  7:10 ` [Qemu-devel] [PATCH 1/2] vhost-user: add multiple queue support Yuanhan Liu
2015-09-15 14:56   ` Eric Blake
2015-09-16  2:07     ` Yuanhan Liu
2015-09-15  7:10 ` [Qemu-devel] [PATCH 2/7] vhost-user: add protocol feature negotiation Yuanhan Liu
2015-09-17  7:12   ` Jason Wang
2015-09-17  7:20     ` Yuanhan Liu
2015-09-15  7:10 ` [Qemu-devel] [PATCH 3/7] vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE Yuanhan Liu
2015-09-15  7:10 ` [Qemu-devel] [PATCH 4/7] vhost-user: add VHOST_USER_GET_QUEUE_NUM message Yuanhan Liu
2015-09-15  7:10 ` [Qemu-devel] [PATCH 5/7] vhost: introduce vhost_backend_get_vq_index method Yuanhan Liu
2015-09-15  7:10 ` [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support Yuanhan Liu
2015-09-15 15:02   ` Eric Blake
2015-09-16  2:06     ` Yuanhan Liu
2015-09-16  2:48       ` Yuanhan Liu
2015-09-16  8:10       ` Michael S. Tsirkin
2015-09-16  8:23         ` Yuanhan Liu [this message]
2015-09-16 14:15       ` Eric Blake
2015-09-16 14:53         ` Yuanhan Liu
2015-09-15  7:10 ` [Qemu-devel] [PATCH 7/7] vhost-user: add a new message to disable/enable a specific virt queue Yuanhan Liu
2015-09-16  8:12 ` [Qemu-devel] [PATCH 0/7 v9] vhost-user multiple queue support Michael S. Tsirkin
2015-09-16  8:17   ` Yuanhan Liu
2015-09-16 11:39 ` Marcel Apfelbaum
2015-09-16 12:23   ` Yuanhan Liu
2015-09-16 14:06     ` Marcel Apfelbaum
2015-09-17 12:23 ` Michael S. Tsirkin
2015-09-18  1:18   ` Yuanhan Liu
  -- strict thread matches above, loose matches on Subject: below --
2015-09-08  7:38 [Qemu-devel] [PATCH 0/7 v7] " Yuanhan Liu
2015-09-08  7:38 ` [Qemu-devel] [PATCH 6/7] vhost-user: add " Yuanhan Liu
2015-09-08 21:22   ` Eric Blake
2015-09-09  1:47     ` Yuanhan Liu
2015-09-09  8:05   ` Ouyang, Changchun
2015-09-09  8:11     ` Yuanhan Liu
2015-09-09 12:18   ` Michael S. Tsirkin
2015-09-09 13:19     ` Yuanhan Liu
2015-09-09 20:55   ` Michael S. Tsirkin
2015-09-14 10:00   ` Jason Wang
2015-09-15  2:15     ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150916082308.GH2339@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=changchun.ouyang@intel.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).