From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zc7yl-0001MC-3T for qemu-devel@nongnu.org; Wed, 16 Sep 2015 04:22:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zc7yh-0002ER-Th for qemu-devel@nongnu.org; Wed, 16 Sep 2015 04:22:11 -0400 Received: from mga14.intel.com ([192.55.52.115]:12730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zc7yh-0002EN-OG for qemu-devel@nongnu.org; Wed, 16 Sep 2015 04:22:07 -0400 Date: Wed, 16 Sep 2015 16:23:08 +0800 From: Yuanhan Liu Message-ID: <20150916082308.GH2339@yliu-dev.sh.intel.com> References: <1442301035-7550-1-git-send-email-yuanhan.liu@linux.intel.com> <1442301035-7550-8-git-send-email-yuanhan.liu@linux.intel.com> <55F832EF.9030500@redhat.com> <20150916020656.GD2339@yliu-dev.sh.intel.com> <20150916110625-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150916110625-mutt-send-email-mst@redhat.com> Subject: Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: jasowang@redhat.com, qemu-devel@nongnu.org, changchun.ouyang@intel.com On Wed, Sep 16, 2015 at 11:10:35AM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 16, 2015 at 10:06:56AM +0800, Yuanhan Liu wrote: > > If not, I'd like to put them into the commit log, as putting it > > outside the commit log gives unnecessary extra burden to patch > > author when he need update several version change information > > in a patch set: he has to format the patch set first, and add > > them one by one by editing those patches. > > I personally just describe the changes in the cover letter. I did that as well. I just thought metioning them inside the patch again will make it clear for you to review. --yliu > > In fact, while not a lot of people do this, git-backport-diff > (from https://github.com/codyprime/git-scripts.git) > is a handy tool to show which patches changed since the > previous version, and it only works if the change log > is in the cover letter. > > Or you can stick --- in the commit log as you have found out - > but that depends on the patch author being careful to log > all edits. > -- > MST