From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcE5L-0006Wh-4Q for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:53:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcE5J-0008NB-T9 for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:53:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcE5J-0008N5-Ob for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:53:21 -0400 Date: Wed, 16 Sep 2015 15:53:17 +0100 From: "Daniel P. Berrange" Message-ID: <20150916145317.GJ21184@redhat.com> References: <1442401589-24189-1-git-send-email-armbru@redhat.com> <1442401589-24189-6-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1442401589-24189-6-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v8 05/26] tests/qapi-schema: Convert test harness to QAPISchemaVisitor Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Wed, Sep 16, 2015 at 01:06:08PM +0200, Markus Armbruster wrote: > The old code prints the result of parsing (list of expression > dictionaries), and partial results of semantic analysis (list of enum > dictionaries, list of struct dictionaries). > > The new code prints a trace of a schema visit, i.e. what the back-ends > are going to use. Built-in and array types are omitted, because > they're boring. > > Signed-off-by: Markus Armbruster > --- > tests/qapi-schema/alternate-good.out | 15 +- > tests/qapi-schema/args-member-array.out | 13 +- > tests/qapi-schema/comments.out | 4 +- > tests/qapi-schema/empty.out | 3 - > tests/qapi-schema/enum-empty.out | 4 +- > tests/qapi-schema/event-case.out | 4 +- > tests/qapi-schema/flat-union-reverse-define.out | 21 ++- > tests/qapi-schema/ident-with-escape.out | 7 +- > tests/qapi-schema/include-relpath.out | 4 +- > tests/qapi-schema/include-repetition.out | 4 +- > tests/qapi-schema/include-simple.out | 4 +- > tests/qapi-schema/indented-expr.out | 7 +- > tests/qapi-schema/qapi-schema-test.out | 217 +++++++++++++++++------- > tests/qapi-schema/returns-int.out | 5 +- > tests/qapi-schema/test-qapi.py | 45 ++++- > tests/qapi-schema/type-bypass.out | 7 +- > 16 files changed, 246 insertions(+), 118 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|