From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcE4J-0004km-CO for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:52:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcE4F-0007yx-6d for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:52:19 -0400 Received: from mga03.intel.com ([134.134.136.65]:63444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcE4F-0007yr-0T for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:52:15 -0400 Date: Wed, 16 Sep 2015 22:53:18 +0800 From: Yuanhan Liu Message-ID: <20150916145318.GJ2339@yliu-dev.sh.intel.com> References: <1442301035-7550-1-git-send-email-yuanhan.liu@linux.intel.com> <1442301035-7550-8-git-send-email-yuanhan.liu@linux.intel.com> <55F832EF.9030500@redhat.com> <20150916020656.GD2339@yliu-dev.sh.intel.com> <55F9799F.3090802@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55F9799F.3090802@redhat.com> Subject: Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: jasowang@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, changchun.ouyang@intel.com On Wed, Sep 16, 2015 at 08:15:59AM -0600, Eric Blake wrote: > On 09/15/2015 08:06 PM, Yuanhan Liu wrote: > > >> Up to here is mostly fine for the commit message. Meanwhile... > >> > >>> v9: per suggested by Jason Wang, we could invoke qemu_chr_add_handlers() > >>> once only, and invoke qemu_find_net_clients_except() at the handler > >>> to gather all related ncs, for initiating all queues. Which addresses > >>> a hidden bug in older verion in a more QEMU-like way. > >>> > >>> v8: set net->dev.vq_index correctly inside vhost_net_init() based on the > >>> value from net->nc->queue_index. > >> > >> ...this chunk here is useful only on the mailing list, and not in git, > >> and therefore, should appear... > > > > Sorry that I may disagree here. > > > > First of all, it does no harm at all to include few old version > > descriptions. Instead, it may give some hints to the reader how > > the patch evolves. Meanwhile, you will find they are quite common > > in some well known open source projects, such as linux kernel: > > There's nothing wrong with including patch changelog in your mail; in > fact it is encouraged by: > http://wiki.qemu.org/Contribute/SubmitAPatch > > However, we DO request that you put it after ---, because we do NOT want > it in qemu.git log. > > I don't care if the kernel has a slightly different policy, and is more > tolerant of changelogs leaked into the git log. > > > > You can find them at qemu project (though not that common), too: > > > > [yliu@yliu-dev ~/qemu]$ git log | grep '\<[vV][1-9][0-9]*:' | wc -l > > 390 > > They're not common for a reason - we've documented that we don't like > them in git. And that's because we expect the --- separator between the > git message and the changelog. > > > > > So, if it's a qemu community specific culture, I could do what > > you suggested. > > Yes, since it is documented at > http://wiki.qemu.org/Contribute/SubmitAPatch, it is qemu culture. Good to know, then. Thanks. --yliu