From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcEAe-0005j7-Lw for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:58:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcEAZ-0002N2-0l for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:58:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcEAY-0002Mw-Lu for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:58:46 -0400 Date: Wed, 16 Sep 2015 15:58:42 +0100 From: "Daniel P. Berrange" Message-ID: <20150916145842.GN21184@redhat.com> References: <1442401589-24189-1-git-send-email-armbru@redhat.com> <1442401589-24189-10-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1442401589-24189-10-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v8 09/26] qapi: De-duplicate enum code generation Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Wed, Sep 16, 2015 at 01:06:12PM +0200, Markus Armbruster wrote: > Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but > that's no excuse. Move the helpers from qapi-types.py to qapi.py, and > replace the duplicates in qapi-event.py. > > The generated event enumeration type's lookup table becomes > const-correct (see commit 2e4450f), and uses explicit indexes instead > of relying on order (see commit 912ae9c). > > Signed-off-by: Markus Armbruster > --- > docs/qapi-code-gen.txt | 9 ++++--- > scripts/qapi-event.py | 67 +++----------------------------------------------- > scripts/qapi-types.py | 55 ----------------------------------------- > scripts/qapi.py | 55 +++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 64 insertions(+), 122 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|