Re: [Qemu-devel] [PATCH v8 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor

["Daniel P. Berrange" <berrange@redhat.com>]

On Wed, Sep 16, 2015 at 01:06:16PM +0200, Markus Armbruster wrote:
> Generate just 'FOO' instead of 'struct FOO' when possible.
> 
> Drop helper functions that are now unused.
> 
> Make pep8 and pylint reasonably happy.
> 
> Rename generate_FOO() functions to gen_FOO() for consistency.
> 
> Use more consistent and sensible variable names.
> 
> Consistently use c_ for mapping keys when their value is a C
> identifier or type.
> 
> Simplify gen_enum() and gen_visit_union()
> 
> Consistently use single quotes for C text string literals.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  docs/qapi-code-gen.txt   |   2 +-
>  scripts/qapi-commands.py | 140 ++++++++++++++++++++++++++---------------------
>  scripts/qapi-event.py    | 122 ++++++++++++++++++++---------------------
>  scripts/qapi-types.py    |  79 ++++++++++++++------------
>  scripts/qapi-visit.py    | 127 ++++++++++++++++++++++--------------------
>  scripts/qapi.py          | 131 +++++++++-----------------------------------
>  6 files changed, 274 insertions(+), 327 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|