From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcECY-00087T-Af for qemu-devel@nongnu.org; Wed, 16 Sep 2015 11:00:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcECU-0003RU-0J for qemu-devel@nongnu.org; Wed, 16 Sep 2015 11:00:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcECT-0003Qd-SF for qemu-devel@nongnu.org; Wed, 16 Sep 2015 11:00:45 -0400 Date: Wed, 16 Sep 2015 16:00:42 +0100 From: "Daniel P. Berrange" Message-ID: <20150916150041.GP21184@redhat.com> References: <1442401589-24189-1-git-send-email-armbru@redhat.com> <1442401589-24189-14-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1442401589-24189-14-git-send-email-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH v8 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On Wed, Sep 16, 2015 at 01:06:16PM +0200, Markus Armbruster wrote: > Generate just 'FOO' instead of 'struct FOO' when possible. > > Drop helper functions that are now unused. > > Make pep8 and pylint reasonably happy. > > Rename generate_FOO() functions to gen_FOO() for consistency. > > Use more consistent and sensible variable names. > > Consistently use c_ for mapping keys when their value is a C > identifier or type. > > Simplify gen_enum() and gen_visit_union() > > Consistently use single quotes for C text string literals. > > Signed-off-by: Markus Armbruster > --- > docs/qapi-code-gen.txt | 2 +- > scripts/qapi-commands.py | 140 ++++++++++++++++++++++++++--------------------- > scripts/qapi-event.py | 122 ++++++++++++++++++++--------------------- > scripts/qapi-types.py | 79 ++++++++++++++------------ > scripts/qapi-visit.py | 127 ++++++++++++++++++++++-------------------- > scripts/qapi.py | 131 +++++++++----------------------------------- > 6 files changed, 274 insertions(+), 327 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|