From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcVf3-0004L2-Rt for qemu-devel@nongnu.org; Thu, 17 Sep 2015 05:39:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcVf3-0004jt-0s for qemu-devel@nongnu.org; Thu, 17 Sep 2015 05:39:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcVf2-0004ia-RP for qemu-devel@nongnu.org; Thu, 17 Sep 2015 05:39:24 -0400 Date: Thu, 17 Sep 2015 11:39:19 +0200 From: Andrew Jones Message-ID: <20150917093919.GC5933@hawk.localdomain> References: <1442455041-6596-1-git-send-email-shannon.zhao@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442455041-6596-1-git-send-email-shannon.zhao@linaro.org> Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix wrong size of flash List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: shannon.zhao@linaro.org Cc: peter.maydell@linaro.org, zhaoshenglong@huawei.com, qemu-devel@nongnu.org, graeme.gregory@linaro.org, peter.huangpeng@huawei.com On Thu, Sep 17, 2015 at 09:57:21AM +0800, shannon.zhao@linaro.org wrote: > From: Shannon Zhao > > While virt machine creates two flash devices with total size 0x08000000, > it wrongly uses this total size for each one. So it will overlap other > MMIO spaces. > > Signed-off-by: Shannon Zhao > --- > hw/arm/virt-acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index 2073573..bc858c8 100644 > --- a/hw/arm/virt-acpi-build.c > +++ b/hw/arm/virt-acpi-build.c > @@ -114,7 +114,7 @@ static void acpi_dsdt_add_flash(Aml *scope, const MemMapEntry *flash_memmap) > { > Aml *dev, *crs; > hwaddr base = flash_memmap->base; > - hwaddr size = flash_memmap->size; > + hwaddr size = flash_memmap->size / 2; > > dev = aml_device("FLS0"); > aml_append(dev, aml_name_decl("_HID", aml_string("LNRO0015"))); > -- > 2.1.0 > > A sentence in the commit message saying that the DT generation also gives each device one half the total size would be nice Reviewed-by: Andrew Jones