From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcWkh-0006vQ-TD for qemu-devel@nongnu.org; Thu, 17 Sep 2015 06:49:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcWke-0005Zs-Il for qemu-devel@nongnu.org; Thu, 17 Sep 2015 06:49:19 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:38549) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcWke-0005ZS-9c for qemu-devel@nongnu.org; Thu, 17 Sep 2015 06:49:16 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 Sep 2015 11:49:15 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 0A3281B08061 for ; Thu, 17 Sep 2015 11:50:55 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t8HAnDl139321722 for ; Thu, 17 Sep 2015 10:49:13 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t8HAnC6K025238 for ; Thu, 17 Sep 2015 04:49:13 -0600 Date: Thu, 17 Sep 2015 12:49:10 +0200 From: Cornelia Huck Message-ID: <20150917124910.14f942e2.cornelia.huck@de.ibm.com> In-Reply-To: <55FA9970.40106@redhat.com> References: <20150916175511.6328fceb@bahia.local> <1442480761-20548-1-git-send-email-cornelia.huck@de.ibm.com> <55FA9970.40106@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio: add some migration doc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: gkurz@linux.vnet.ibm.com, kraxel@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On Thu, 17 Sep 2015 18:44:00 +0800 Jason Wang wrote: > > > On 09/17/2015 05:06 PM, Cornelia Huck wrote: > > Try to cover the basics of virtio migration. > > > > Signed-off-by: Cornelia Huck > > --- > > It might help if we add some documentation; at the very least, it will > > prevent myself getting a headache everytime I look at that code :) > > > > Feedback welcome. > > --- > > docs/virtio-migration.txt | 101 ++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 101 insertions(+) > > create mode 100644 docs/virtio-migration.txt > > Thanks for the patch. Looks good to me. Keeping this doc to be synced > with code is important in the future. E.g I add a new subsection in core > with my pci virtio 1.0 fixes. Yes, that's a drawback of the "document it" approach...