From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zd0la-0000bP-H8 for qemu-devel@nongnu.org; Fri, 18 Sep 2015 14:52:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zd0lX-0002T6-Ba for qemu-devel@nongnu.org; Fri, 18 Sep 2015 14:52:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zd0lX-0002Sx-7B for qemu-devel@nongnu.org; Fri, 18 Sep 2015 14:52:11 -0400 Date: Fri, 18 Sep 2015 19:52:06 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20150918185205.GA2588@work-vm> References: <1442406595-14296-1-git-send-email-pbonzini@redhat.com> <1442406595-14296-18-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442406595-14296-18-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PULL 17/24] translate: move real_host_page setting to -common List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Crosthwaite , qemu-devel@nongnu.org, Peter Crosthwaite * Paolo Bonzini (pbonzini@redhat.com) wrote: > From: Peter Crosthwaite > > Move the size and mask globals for the "real" host page size to > translate-common. This is to allow system-level code to use > REAL_HOST_PAGE_ALIGN and friends in builds which hide translate-all > behind arch-obj. Are you intending to move the include definitions as well, because I still can't use those definitions because they're still in cpu-all.h which is tainted if I try and include it in anything not target-specific. Dave > Cc: dgilbert@redhat.com > Signed-off-by: Peter Crosthwaite > Message-Id: > Signed-off-by: Paolo Bonzini > --- > translate-all.c | 2 -- > translate-common.c | 3 +++ > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/translate-all.c b/translate-all.c > index 0140255..4a9ee33 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -117,8 +117,6 @@ typedef struct PageDesc { > > #define V_L1_SHIFT (L1_MAP_ADDR_SPACE_BITS - TARGET_PAGE_BITS - V_L1_BITS) > > -uintptr_t qemu_real_host_page_size; > -uintptr_t qemu_real_host_page_mask; > uintptr_t qemu_host_page_size; > uintptr_t qemu_host_page_mask; > > diff --git a/translate-common.c b/translate-common.c > index 681e2bf..619feb4 100644 > --- a/translate-common.c > +++ b/translate-common.c > @@ -20,6 +20,9 @@ > #include "qemu-common.h" > #include "qom/cpu.h" > > +uintptr_t qemu_real_host_page_size; > +uintptr_t qemu_real_host_page_mask; > + > #ifndef CONFIG_USER_ONLY > /* mask must never be zero, except for A20 change call */ > static void tcg_handle_interrupt(CPUState *cpu, int mask) > -- > 2.5.0 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK