From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdBdB-00060Z-5A for qemu-devel@nongnu.org; Sat, 19 Sep 2015 02:28:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZdBd9-0007O9-TO for qemu-devel@nongnu.org; Sat, 19 Sep 2015 02:28:17 -0400 Date: Sat, 19 Sep 2015 16:28:27 +1000 From: David Gibson Message-ID: <20150919062827.GD29031@voom.redhat.com> References: <1442557816-23067-1-git-send-email-gwshan@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="n/aVsWSeQ4JHkrmm" Content-Disposition: inline In-Reply-To: <1442557816-23067-1-git-send-email-gwshan@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH RFC 0/4] sPAPR: Support multiple PEs in one PHB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gavin Shan Cc: alex.williamson@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org --n/aVsWSeQ4JHkrmm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 18, 2015 at 04:30:12PM +1000, Gavin Shan wrote: > This patchset bases on David Gibson's git tree: git://github.com/dgibson/= qemu.git > (branch: vfio). And it requires host kernel changes which is being review= ed > this moment. >=20 > https://patchwork.ozlabs.org/patch/519135/ > https://patchwork.ozlabs.org/patch/519136/ >=20 > Currently, EEH works with the assumption that every sPAPRPHBState, which > is associated with VFIO container in VFIO case, only has one attached > IOMMU group (PE). The request EEH opertion (like reset) is applied to > all PEs attached to the specified sPAPRPHBState. It breaks the affected > boundary of the EEH operation if the sPAPRPHBState supports multiple > IOMMU groups (PEs). >=20 > The patchset intends to resolve above issue by using the newly exposed > EEH v2 API interface, which accepts IOMMU group (PE) to specify the > affected domain of the requested EEH operation: Every PE is identified > with PE address, which is the (PE's primary bus ID + 1) previously. > After this patchset, it's changed to (IOMMU group ID + 1). The PE adress > is passed on every requested EEH operation from guest so that it can > be passed to host to affect the target PE only. Sorry Gavin, I've been working on this problem from the other end - trying to get qemu to work safely with EEH to the limited extent that's possible with the existing kernel interface, and also getting rid of the special VFIO host bridge nonsense at the same time. My code is at git://github.com/dgibson/qemu.git, branch 'eeh'. I plan to post as soon as I've given it at least some minimal testing. It collides with these patches so they'll need a substantial reworking. Fwiw, I'd also prefer if you tackled this by first altering the PE config_addr allocation in qemu so that we can get it working with the existing broken kernel interface, as long as there is only one vfio group per container (put there could be multiple containers on a PHB). Then, the fixed kernel interface can be added on top of that, to remove the one-group-per-container restriction. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --n/aVsWSeQ4JHkrmm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV/QCLAAoJEGw4ysog2bOS2YoP/R2f9MF9gNV5xvOuUtKUCdF9 LvGpiQ1u0deg3lwxWt2689wrbzHtIcUDJQ/dcfHxA+klzwNC9sTqhmkqtDBGM7mD KcsCELGD+eUO1gZJh7E1JYJASSua0V4n5vtmGgtbq3CE513zalnuvfI7jjmwTnB6 0mcZcTUhEPzn8KS0v3fV1tu9b+dhgzR5l0hszrVUm22lm/mBulxFWy0fjA+vRxEi BhcVJ/mkzsrOFXtGLzKq4adubYBLnAQCvPZxIv6j3lJZqVluuH7DcLj74Wg89cIP McubYa1S5wVcE6n2rhHEO4tTl4dOFSDoPJ6wRYjYpzDvGw6uoIuZwMPnOb3aVgHu 7skgSzuM7QsQgFekKRhgQrU9sSDrBhG3Rk6A/6DLV/uSXXmeDw/O4gRbb5KV5KBD DkQyqcOQWfmqCbUwLqjSM+yAg+g+2Wo9gnibdtAOGZyNn64w6VNMx2fWf5oWkL+E t6fNy0ZcRXUOBfX0NjBHQFL83yL2wD65x4bfjEvW0rt+1+trXtBMBNvkyJxMhIqq pyzzuhdlaoCwViaymr7pgmbJyaotIOqxnCtCNcOMayE1rRA1Sc1UaVz/XF0Fdpcx HijWUcxp6dTxvuASrbQhVlG3ClMlmQSWDbJDGP2WuDiGcsf8lWcZWIGydIegpez9 x4ppYJEJ1tYzBh/4odkW =V9Ob -----END PGP SIGNATURE----- --n/aVsWSeQ4JHkrmm--