From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39068)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <j.neuschaefer@gmx.net>) id 1Zdtk6-0000ao-3g
	for qemu-devel@nongnu.org; Mon, 21 Sep 2015 01:34:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <j.neuschaefer@gmx.net>) id 1Zdtk2-000598-Tp
	for qemu-devel@nongnu.org; Mon, 21 Sep 2015 01:34:22 -0400
Received: from mout.gmx.net ([212.227.15.15]:53825)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <j.neuschaefer@gmx.net>) id 1Zdtk2-00056Q-Ni
	for qemu-devel@nongnu.org; Mon, 21 Sep 2015 01:34:18 -0400
Date: Mon, 21 Sep 2015 07:34:15 +0200
From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
Message-ID: <20150921053415.GA21776@latitude>
References: <CAFEAcA_NfPiiz5sKp6pvQzs-yr_zd2bsJx+d__d7MxoutJdRTA@mail.gmail.com>
	<20150903052726.GD1761@latitude>
	<CAFEAcA9Xq7+cEnjCrc5ULjLWVvwGqy4Qg+RDC0JHzLY1vCOygg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAFEAcA9Xq7+cEnjCrc5ULjLWVvwGqy4Qg+RDC0JHzLY1vCOygg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of
 multiple headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Riku Voipio <riku.voipio@iki.fi>, Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>, QEMU Developers <qemu-devel@nongnu.org>

On Fri, Sep 04, 2015 at 01:48:39PM +0100, Peter Maydell wrote:
> On 3 September 2015 at 06:27, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
> > Currently, __target_cmsg_nxthdr compares a pointer derived from
> > target_cmsg against the msg_control field of target_msgh (through
> > subtraction).  This failed for me when emulating i386 code under x86_64,
> > because pointers in the host address space and pointers in the guest
> > address space were not the same.  This patch passes the initial value of
> > target_cmsg into __target_cmsg_nxthdr.
> >
> > I found and fixed two more related bugs:
> > - __target_cmsg_nxthdr now returns the new cmsg pointer instead of the
> >   old one.
> > - tgt_space (in host_to_target_cmsg) doesn't count "sizeof (struct
> >   target_cmsghdr)" twice anymore.
> >
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Ping.

What's the status of this patch?


Regards,
Jonathan