From: Riku Voipio <riku.voipio@iki.fi>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers
Date: Mon, 21 Sep 2015 12:45:21 -0700 [thread overview]
Message-ID: <20150921194521.GA30782@beaming.home> (raw)
In-Reply-To: <CAFEAcA9+M9+2k2MvEJ2SpmnZ7TxxGSuDUbwHEri8We2p+gEYzg@mail.gmail.com>
On Mon, Sep 21, 2015 at 06:13:57AM -0700, Peter Maydell wrote:
> On 20 September 2015 at 22:34, Jonathan Neuschäfer
> <j.neuschaefer@gmx.net> wrote:
> > On Fri, Sep 04, 2015 at 01:48:39PM +0100, Peter Maydell wrote:
> >> On 3 September 2015 at 06:27, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
> >> > Currently, __target_cmsg_nxthdr compares a pointer derived from
> >> > target_cmsg against the msg_control field of target_msgh (through
> >> > subtraction). This failed for me when emulating i386 code under x86_64,
> >> > because pointers in the host address space and pointers in the guest
> >> > address space were not the same. This patch passes the initial value of
> >> > target_cmsg into __target_cmsg_nxthdr.
> >> >
> >> > I found and fixed two more related bugs:
> >> > - __target_cmsg_nxthdr now returns the new cmsg pointer instead of the
> >> > old one.
> >> > - tgt_space (in host_to_target_cmsg) doesn't count "sizeof (struct
> >> > target_cmsghdr)" twice anymore.
> >> >
> >> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> >>
> >> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> >
> > Ping.
> >
> > What's the status of this patch?
> It's waiting for Riku to wake up and put it into a linux-user
> pull request.
My intention was to gather a pull request before this travel, but
alas I was stuck with other stuff. I'll get it done next week latest.
Riku
next prev parent reply other threads:[~2015-09-21 19:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 14:50 [Qemu-devel] [PATCH] linux-user: fix host_to_target_cmsg in case of multiple headers Jonathan Neuschäfer
2015-08-27 18:06 ` Peter Maydell
2015-08-29 16:04 ` Jonathan Neuschäfer
2015-08-29 16:35 ` Peter Maydell
2015-08-31 19:27 ` [Qemu-devel] [PATCH] linux-user: fix cmsg conversion " Jonathan Neuschäfer
2015-09-01 15:45 ` Peter Maydell
2015-09-02 3:12 ` Jonathan Neuschäfer
2015-09-03 5:27 ` Jonathan Neuschäfer
2015-09-04 12:48 ` Peter Maydell
2015-09-21 5:34 ` Jonathan Neuschäfer
2015-09-21 13:13 ` Peter Maydell
2015-09-21 19:45 ` Riku Voipio [this message]
2015-09-21 19:50 ` Jonathan Neuschäfer
2015-09-28 13:38 ` Riku Voipio
2015-09-28 22:07 ` Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921194521.GA30782@beaming.home \
--to=riku.voipio@iki.fi \
--cc=j.neuschaefer@gmx.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).