From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeMZC-000507-VI for qemu-devel@nongnu.org; Tue, 22 Sep 2015 08:21:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeMZ9-0006Fd-RV for qemu-devel@nongnu.org; Tue, 22 Sep 2015 08:21:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeMZ9-0006Ee-M0 for qemu-devel@nongnu.org; Tue, 22 Sep 2015 08:20:59 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 42141C0A149D for ; Tue, 22 Sep 2015 12:20:59 +0000 (UTC) Date: Tue, 22 Sep 2015 13:20:56 +0100 From: "Daniel P. Berrange" Message-ID: <20150922122056.GM28888@redhat.com> References: <1442582350-9179-1-git-send-email-berrange@redhat.com> <1442582350-9179-10-git-send-email-berrange@redhat.com> <560143D3.70503@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <560143D3.70503@redhat.com> Subject: Re: [Qemu-devel] [PATCH v1 09/16] io: pull Buffer code out of VNC module Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Gerd Hoffmann , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" On Tue, Sep 22, 2015 at 02:04:35PM +0200, Paolo Bonzini wrote: > > > On 18/09/2015 15:19, Daniel P. Berrange wrote: > > The Buffer code in the VNC server is useful for the IO channel > > code, so pull it out into a shared module, QIOBuffer. > > Do all traces disappear from VNC once you're done? If not, can you > instead move it to util/? It is still used in VNC code for decoding of various framebuffer encodings. Only the websock usage gets eliminated. I'm happy to move it to util/ directory. Any preference on a name for the APIs. I used QIOBuffer since i placed it under io/ directory. Could keep that name when moved to util/, or give it a different one. > > Signed-off-by: Daniel P. Berrange > > --- > > include/io/buffer.h | 118 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > > io/Makefile.objs | 3 +- > > io/buffer.c | 65 +++++++++++++++++++++++++++++ > > ui/vnc-auth-sasl.c | 4 +- > > ui/vnc-enc-tight.c | 38 ++++++++--------- > > ui/vnc-enc-zlib.c | 6 +-- > > ui/vnc-enc-zrle.c | 18 ++++---- > > ui/vnc-jobs.c | 15 +++---- > > ui/vnc-ws.c | 36 ++++++++-------- > > ui/vnc-ws.h | 6 +-- > > ui/vnc.c | 67 ++++++----------------------- > > ui/vnc.h | 50 ++++++++-------------- > > 12 files changed, 277 insertions(+), 149 deletions(-) > > create mode 100644 include/io/buffer.h > > create mode 100644 io/buffer.c Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|