From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49992)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZeOKo-0006nC-49
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:14:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZeOKn-0002Vs-2Z
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:14:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48991)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZeOKm-0002V7-UO
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:14:17 -0400
Date: Tue, 22 Sep 2015 15:14:12 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20150922141412.GY28888@redhat.com>
References: <1442928883-4119-1-git-send-email-mst@redhat.com>
	<20150922134804.GW28888@redhat.com>
	<20150922170804-mutt-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150922170804-mutt-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] mingw: fix build on Fedora 22
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Igor Mammedov <imammedo@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Stefan Weil <sw@weilnetz.de>, "Denis V. Lunev" <den@openvz.org>

On Tue, Sep 22, 2015 at 05:08:44PM +0300, Michael S. Tsirkin wrote:
> On Tue, Sep 22, 2015 at 02:48:04PM +0100, Daniel P. Berrange wrote:
> > 
> > I don't think this is right. There are three possibilities
> > with mingw
> > 
> >  - No gmtime_r at all  - need replacement
> >  - gmtime_r defined as a macro - need replacement
> >  - gmtime_r defined as a function - nothing needed
> > 
> > With this change of yours, if gmtime_r is defined as a macro
> > QEMU will provide its own replacement. If gmtime_r is not
> > defined at all, then QEMU doesn't provide its replacement
> > which is wrong. I believe the change I previously proposed
> > works in all three cases
> > 
> > https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01926.html
> > 
> Good point.
> Can you bounce me your patch pls?

I just sent it as a REPOST, with everyone on this thread CC'd.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|