From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeOoo-0001UI-EK for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:45:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeOon-0006wB-Mg for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:45:18 -0400 Date: Tue, 22 Sep 2015 16:45:07 +0200 From: Kevin Wolf Message-ID: <20150922144507.GH3999@noname.str.redhat.com> References: <1442589793-7105-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442589793-7105-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 00/38] blockdev: BlockBackend and media List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Alberto Garcia , qemu-block@nongnu.org, John Snow , qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi Am 18.09.2015 um 17:22 hat Max Reitz geschrieben: > This series reworks a lot regarding BlockBackend and media. Basically, > it allows empty BlockBackends, that is BBs without a BDS tree. > > Before this series, empty drives are represented by a BlockBackend with > an empty BDS attached to it (a BDS with a NULL driver). However, now we > have BlockBackends, thus an empty drive should be represented by a > BlockBackend without any BDS tree attached to it. This is what this > series does. Patches 1-16 and 18: Reviewed-by: Kevin Wolf I had comments for 17 and 19-21, and can't seem to find a base commit that patch 22 applies cleanly to, so I'm stopping the review here, waiting for another rebase or instructions how to apply the series. Kevin