From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeP1m-0002EK-IM for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:58:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeP1l-000474-BT for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:58:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeP1l-00046s-7Z for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:58:41 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id D8E98AAF for ; Tue, 22 Sep 2015 14:58:40 +0000 (UTC) Date: Tue, 22 Sep 2015 15:58:38 +0100 From: "Daniel P. Berrange" Message-ID: <20150922145837.GZ28888@redhat.com> References: <87mw8rumhb.fsf@blackfin.pond.sub.org> <87y4s8h5rh.fsf@blackfin.pond.sub.org> <876132olyi.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <876132olyi.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel On Tue, Sep 22, 2015 at 11:13:57AM +0200, Markus Armbruster wrote: > Paolo asked for an update. > > Markus Armbruster writes: > > > Markus Armbruster writes: > Different tack: what are the unmaintained files we actually change? > > Unmaintained files sorted by number of commits in the past year (commit > 1733681): > > $ for i in `cat unmaintained-files`; do echo -n "$i "; git-rev-list 1733681.. $i | wc -l; done | awk '{ printf "%7d %s\n", $2, $1 }' | sort -rn | head -n 100 > 79 trace-events We should probably just kill the trace-events file from git entirely. Everyone more or less appends to it, which guarantees each patch series conflicts on it, and no one person is suitable as maintainer of it really. My personal suggestion would be to have a .t file alongside each source file which has trace events in it. eg if ui/vnc.c includes trace events, then put all VNC trace events in a ui/vnc.t file. The Makefile can trivially concatenate all .t files back into a single trace-events file. This way, we can trivially align maintainers for the .t files with the corresponding maintainer of the .c file. There might be some cases where trace events are used from multiple source files, in which case you could allow a common.t file in each subdirectory too. This gets slightly harder to assign a unique maintainer against though particularly for a dumping ground like util/ or block/ etc, so I'd suggest focusing on .t files matching the .c filename. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|