From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41430)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ZePPe-0004Qs-76
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 11:23:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ZePPd-0000sl-GT
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 11:23:22 -0400
Date: Tue, 22 Sep 2015 17:23:13 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20150922152313.GK3999@noname.str.redhat.com>
References: <1442582574-14275-1-git-send-email-armbru@redhat.com>
	<1442582574-14275-3-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1442582574-14275-3-git-send-email-armbru@redhat.com>
Subject: Re: [Qemu-devel] [PULL 2/8] hmp: Allow for error message hints on
	HMP
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org

Am 18.09.2015 um 15:22 hat Markus Armbruster geschrieben:
> From: Eric Blake <eblake@redhat.com>
> 
> Commits 7216ae3d and d2828429 disabled some error message hints,
> all because a change to use modern error reporting meant that the
> hint would be output prior to the actual error.  Fix this by making
> hints a first-class member of Error.
> 
> For example, we are now back to the pleasant:
> 
>  $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,
>  qemu-system-x86_64: --chardev null,id=,: Parameter 'id' expects an identifier
>  Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Message-Id: <1441901956-21991-1-git-send-email-eblake@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

This broke qemu-iotests 049. Can you please send a patch to update the
reference output?

Kevin

--- /home/kwolf/source/qemu/tests/qemu-iotests/049.out  2015-09-14 13:44:45.347890767 +0200
+++ 049.out.bad 2015-09-22 17:20:50.131625409 +0200
@@ -118,6 +118,7 @@
 
 qemu-img create -f qcow2 -o size=foobar TEST_DIR/t.qcow2
 qemu-img: Parameter 'size' expects a size
+You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and terabytes.
 qemu-img: TEST_DIR/t.qcow2: Invalid options for file format 'qcow2'
 
 == Check correct interpretation of suffixes for cluster size ==