From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47976)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1ZeZ8V-0005Q9-6l
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 21:46:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1ZeZ8Q-0003HS-76
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 21:46:19 -0400
Received: from mga03.intel.com ([134.134.136.65]:60427)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yuanhan.liu@linux.intel.com>) id 1ZeZ8Q-0003Gz-0c
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 21:46:14 -0400
Date: Wed, 23 Sep 2015 09:48:21 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Message-ID: <20150923014821.GZ2339@yliu-dev.sh.intel.com>
References: <1442588324-11365-1-git-send-email-yuanhan.liu@linux.intel.com>
	<1442588324-11365-7-git-send-email-yuanhan.liu@linux.intel.com>
	<20150922185249.GE13681@thinpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150922185249.GE13681@thinpad.lan.raisama.net>
Subject: Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue
 support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: jasowang@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, Changchun.ouyang@hotmail.com, Changchun Ouyang <changchun.ouyang@intel.com>

On Tue, Sep 22, 2015 at 03:52:49PM -0300, Eduardo Habkost wrote:
> On Fri, Sep 18, 2015 at 10:58:43PM +0800, Yuanhan Liu wrote:
> [...]
> > diff --git a/net/vhost-user.c b/net/vhost-user.c
> > index 93dcecd..4fa3d64 100644
> > --- a/net/vhost-user.c
> > +++ b/net/vhost-user.c
> [...]
> > +        if (i == 0) {
> > +            max_queues = vhost_net_get_max_queues(s->vhost_net);
> 
> This breaks arm-softmmu (and any target that doesn't have CONFIG_VHOST_NET):

Thanks for testing. Will fix it next version.

	--yliu
> 
>   $ make subdir-arm-softmmu
>     CC    arm-softmmu/hw/net/vhost_net.o
>     LINK  arm-softmmu/qemu-system-arm
>   ../net/vhost-user.o: In function `vhost_user_start':
>   /home/ehabkost/rh/proj/virt/qemu/net/vhost-user.c:88: undefined reference to `vhost_net_get_max_queues'
>   collect2: error: ld returned 1 exit status
>   Makefile:193: recipe for target 'qemu-system-arm' failed
>   make[1]: *** [qemu-system-arm] Error 1
>   Makefile:184: recipe for target 'subdir-arm-softmmu' failed
>   make: *** [subdir-arm-softmmu] Error 2
> 
> -- 
> Eduardo