From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZehMJ-0005Pa-Rx for qemu-devel@nongnu.org; Wed, 23 Sep 2015 06:33:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZehMG-0004b9-MJ for qemu-devel@nongnu.org; Wed, 23 Sep 2015 06:33:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZehMG-0004az-Hf for qemu-devel@nongnu.org; Wed, 23 Sep 2015 06:33:04 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id E31632FAA70 for ; Wed, 23 Sep 2015 10:33:03 +0000 (UTC) Date: Wed, 23 Sep 2015 11:32:59 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20150923103259.GE2655@work-vm> References: <1442836223-282767-1-git-send-email-imammedo@redhat.com> <55FFF67F.5070701@redhat.com> <20150923113644.28c31559@nial.brq.redhat.com> <56027330.9010309@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56027330.9010309@redhat.com> Subject: Re: [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter , ehabkost@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, Igor Mammedov , Jiri * Paolo Bonzini (pbonzini@redhat.com) wrote: > > > On 23/09/2015 11:36, Igor Mammedov wrote: > > Also it's QEMU bug/fault and pushing workaround to upper layers > > doesn't seem right when it's much easier to do it in QEMU itself. > > No, it's virtio's bug. It makes sense to push workaround for guest bugs > as far from the hypervisor as possible. But you really don't want to have higher level things having to align addresses themselves. I could see adding an option for the required alignment would be OK. > If we want to increase the alignment in QEMU, I would prefer to have > natural alignment which makes some sense and happens to work around the > bug as well. Michael, Eduardo, any third opinions? > By natural alignment do you mean that an 'n MB' DIMM gets aligned to 'n MB' ? Dave > Paolo -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK