Re: [Qemu-devel] [PATCH 1/2] Move dirty page search state into separate structure

[Amit Shah <amit.shah@redhat.com>]

On (Wed) 16 Sep 2015 [19:11:53], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> Pull the sarch state for one iteration of the dirty page

typo in 'search'

> search into a structure.
> 
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> @@ -923,26 +933,29 @@ static int ram_save_compressed_page(QEMUFile *f, RAMBlock *block,
>  static int ram_find_and_save_block(QEMUFile *f, bool last_stage,
>                                     uint64_t *bytes_transferred)
>  {
> -    RAMBlock *block = last_seen_block;
> -    ram_addr_t offset = last_offset;
> -    bool complete_round = false;
> +    PageSearchStatus pss;
>      int pages = 0;
>  
> -    if (!block)
> -        block = QLIST_FIRST_RCU(&ram_list.blocks);
> +    pss.block = last_seen_block;
> +    pss.offset = last_offset;
> +    pss.complete_round = false;
> +
> +    if (!pss.block)
> +        pss.block = QLIST_FIRST_RCU(&ram_list.blocks);

Missing {} around if

With those fixed:

Reviewed-by: Amit Shah <amit.shah@redhat.com>


		Amit