From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZejmN-0006xR-Vq for qemu-devel@nongnu.org; Wed, 23 Sep 2015 09:08:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZejmJ-0000be-UX for qemu-devel@nongnu.org; Wed, 23 Sep 2015 09:08:11 -0400 Received: from smtp.andrew.cmu.edu ([128.2.157.37]:45943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZejmJ-0000ap-Pq for qemu-devel@nongnu.org; Wed, 23 Sep 2015 09:08:07 -0400 Date: Wed, 23 Sep 2015 09:07:51 -0400 From: "Gabriel L. Somlo" Message-ID: <20150923130751.GA2080@HEDWIG.INI.CMU.EDU> References: <1442501794-27112-1-git-send-email-somlo@cmu.edu> <20150923115005.28400c24@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20150923115005.28400c24@nial.brq.redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 0/5] add ACPI node for fw_cfg on pc and arm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, drjones@redhat.com, matt.fleming@intel.com, ehabkost@redhat.com, mst@redhat.com, ard.biesheuvel@linaro.org, qemu-devel@nongnu.org, leif.lindholm@linaro.org, kevin@koconnor.net, kraxel@redhat.com, zhaoshenglong@huawei.com, pbonzini@redhat.com, markmb@redhat.com, lersek@redhat.com, rth@twiddle.net On Wed, Sep 23, 2015 at 11:50:05AM +0200, Igor Mammedov wrote: > On Thu, 17 Sep 2015 10:56:29 -0400 > "Gabriel L. Somlo" wrote: >=20 > > New since v2: > >=20 > > - pc/i386 node in ssdt only on machine types *newer* than 2.4 > > (as suggested by Eduardo) > >=20 > > I appreciate any further comments and reviews. Hopefully we can make > > this palatable for upstream, modulo the lingering concerns about whet= her > > "QEMU0002" is ok to use as the value of _HID, which I'll hopefully ge= t > > sorted out with the kernel crew... > >=20 > > Thanks much, > > --Gabriel > >=20 > > >New since v1: > > > > > > - expose control register size (suggested by Marc Mar=ED) > > > > > > - leaving out _UID and _STA fields (thanks Shannon & Igor) > > > > > > - using "QEMU0002" as the value of _HID (thanks Michael) > > > > > > - added documentation blurb to docs/specs/fw_cfg.txt > > > (mainly to record usage of the "QEMU0002" string with fw_cfg). > > > > > >> This series adds a fw_cfg device node to the SSDT (on pc), or to t= he > > >> DSDT (on arm). > > >> > > >> - Patch 1/3 moves (and renames) the BIOS_CFG_IOPORT (0x510) > > >> define from pc.c to pc.h, so that it could be used from > > >> acpi-build.c in patch 2/3. > > >>=20 >=20 > > >> - Patch 2/3 adds a fw_cfg node to the pc SSDT. > > >>=20 > > >> - Patch 3/3 adds a fw_cfg node to the arm DSDT. > ACPI patches 2-3 look fine to me > although there is one but, it will make Windows complain about > unknown device and prompt user to install driver. I wonder if the implicit _STA has bit 2 (visible to u/i) implicitly enabled (0x0F vs. 0x0B)... I'll try to reproduce this myself, and see if adding (back) the explicit _STA value helps. Thanks! --Gabriel >=20 > > >> > > >> I made up some names - "FWCF" for the node name, and "FWCF0001" > > >> for _HID; no idea whether that's appropriate, or how else I should > > >> figure out what to use instead... > > >> > > >> Also, using scope "\\_SB", based on where fw_cfg shows up in the > > >> output of "info qtree". Again, if that's wrong, please point me in > > >> the right direction. > > >> > > >> Re. 3/3 (also mentioned after the commit blurb in the patch itself= ), > > >> I noticed none of the other DSDT entries contain a _STA field, won= dering > > >> why it would (not) make sense to include that, same as on the PC. > >=20 > > Gabriel L. Somlo (5): > > fw_cfg: expose control register size in fw_cfg.h > > pc: fw_cfg: move ioport base constant to pc.h > > acpi: pc: add fw_cfg device node to ssdt > > acpi: arm: add fw_cfg device node to dsdt > > fw_cfg: document ACPI device node information > >=20 > > docs/specs/fw_cfg.txt | 9 +++++++++ > > hw/arm/virt-acpi-build.c | 13 +++++++++++++ > > hw/i386/acpi-build.c | 21 +++++++++++++++++++++ > > hw/i386/pc.c | 5 ++--- > > hw/i386/pc_piix.c | 1 + > > hw/i386/pc_q35.c | 1 + > > hw/nvram/fw_cfg.c | 8 +++++--- > > include/hw/i386/pc.h | 3 +++ > > include/hw/nvram/fw_cfg.h | 3 +++ > > 9 files changed, 58 insertions(+), 6 deletions(-) > >=20 >=20