From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38067)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1ZenT0-0006C7-2z
	for qemu-devel@nongnu.org; Wed, 23 Sep 2015 13:04:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1ZenSx-0005rz-Dn
	for qemu-devel@nongnu.org; Wed, 23 Sep 2015 13:04:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51138)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1ZenSx-0005rt-8c
	for qemu-devel@nongnu.org; Wed, 23 Sep 2015 13:04:23 -0400
Date: Wed, 23 Sep 2015 18:04:15 +0100
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20150923170415.GC13453@work-vm>
References: <1434450415-11339-1-git-send-email-dgilbert@redhat.com>
	<1434450415-11339-24-git-send-email-dgilbert@redhat.com>
	<20150721103307.GH10280@grmbl.mre>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150721103307.GH10280@grmbl.mre>
Subject: Re: [Qemu-devel] [PATCH v7 23/42] MIGRATION_STATUS_POSTCOPY_ACTIVE:
 Add new migration state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, quintela@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, pbonzini@redhat.com, david@gibson.dropbear.id.au

* Amit Shah (amit.shah@redhat.com) wrote:
> On (Tue) 16 Jun 2015 [11:26:36], Dr. David Alan Gilbert (git) wrote:
> 
> > -    if (s->state == MIGRATION_STATUS_ACTIVE ||
> > -        s->state == MIGRATION_STATUS_SETUP) {
> > +    if (migration_already_active(s)) {
> 
> (I know, not introduced here, but:)
> 
> A better name is migration_is_active()

Done.

> 
> > +bool migration_postcopy_phase(MigrationState *s)
> > +{
> > +    return (s->state == MIGRATION_STATUS_POSTCOPY_ACTIVE);
> > +}
> 
> And this is better named migration_in_postcopy()

Done

> 
> otherwise,
> 
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
> 
> 
> 
> 		Amit
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK