From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZevfO-0007xi-83 for qemu-devel@nongnu.org; Wed, 23 Sep 2015 21:49:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZevfL-0002sv-1f for qemu-devel@nongnu.org; Wed, 23 Sep 2015 21:49:46 -0400 Date: Thu, 24 Sep 2015 11:16:13 +1000 From: David Gibson Message-ID: <20150924011613.GL15944@voom.fritz.box> References: <1442647117-2726-1-git-send-email-david@gibson.dropbear.id.au> <1442647117-2726-10-git-send-email-david@gibson.dropbear.id.au> <1443029323.23936.484.camel@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GeDkoc8jIzHasOdk" Content-Disposition: inline In-Reply-To: <1443029323.23936.484.camel@redhat.com> Subject: Re: [Qemu-devel] [RFC PATCH 09/14] vfio: Expose a VFIO PCI device's group for EEH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: lvivier@redhat.com, thuth@redhat.com, mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, qemu-devel@nongnu.org, gwshan@linux.vnet.ibm.com, qemu-ppc@nongnu.org --GeDkoc8jIzHasOdk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 23, 2015 at 11:28:43AM -0600, Alex Williamson wrote: > On Sat, 2015-09-19 at 17:18 +1000, David Gibson wrote: > > The Enhanced Error Handling (EEH) interface in PAPR operates on units o= f a > > Partitionable Endpoint (PE). For VFIO devices, the PE boundaries the g= uest > > sees must match the PE (i.e. IOMMU group) boundaries on the host. To > > implement this VFIO needs to expose to EEH the IOMMU group each VFIO de= vice > > belongs to. > >=20 > > Add a vfio_pci_device_group() function to the VFIO/EEH interface for th= is > > purpose. > >=20 > > Signed-off-by: David Gibson > > --- > > hw/vfio/pci.c | 13 +++++++++++++ > > include/hw/vfio/vfio-eeh.h | 1 + > > 2 files changed, 14 insertions(+) > >=20 > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > > index 73d34b9..29f9467 100644 > > --- a/hw/vfio/pci.c > > +++ b/hw/vfio/pci.c > > @@ -41,6 +41,7 @@ > > #include "trace.h" > > #include "hw/vfio/vfio.h" > > #include "hw/vfio/vfio-common.h" > > +#include "hw/vfio/vfio-eeh.h" >=20 >=20 > Why? EEH may be the consumer, but it's not EEH specific, it should not > have the prototype in an EEH specific header. Ok, planning to create a vfio-pci.h in the respin. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --GeDkoc8jIzHasOdk Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWA07dAAoJEGw4ysog2bOS/3UQAKOOd+8I1fBQNsFqg8lDltqE ctSDyGBLVv51N8+I4VVa6zMvqIwweZvBiNpTFpLoKXXLmMvPNJWhRiAoKUb7wZM/ LpR5ZcmN/TXWLgw29CioiwpMyQ096F3rFFiaUx7slKDQDid0OcXA4OxS/kT9y8YZ okL8mv+Jhq1+AUZ6CE9UbXNhKlr5A/XCtO1AirAQQC3+hLElnPRF1HEIkBVgZdsV hoZrodjtYwDhkHFf0Q+0zp9zU03rEZgw1Qerax8wmrBfup/GBOUr2+KHm3JtYPAY fKYbPyZ66mSMH+Wcu5C+Pg2Nzzn51cC9vk0irgQoZTNbVKnK99wQuD+2f/0lEmTo Ai6285VISV71ZGBMeXf4WDDGgT/UFzuWS7xF58ltsHENd/zhor1x3WjqDncEanw/ 9frRhWTNOYx2hMQnsM1/ekAtyOp973yjkpH+Q268hUqSZ0mMCtPZLVHEKq8honWh pMoD41cBJU+LfqjIB0VMP5dEvH9hCRfBiOuwfyY76BRuHz+z+uuCU5G0SW9AqaUi 12zNXf+3T0qd2HNiaOpDFIsWmARLQZnZ6DZZfkJMFM4qVexKwbKycZfL9QnPo9Zw NzuSrKxk/hkctMiatQJtFbXTLrfjB0uRoa7WleJ2+9whodhv7Sb0w3v2L5Zx5282 G1AlfNg7J6IrqZLEcZXW =dl1N -----END PGP SIGNATURE----- --GeDkoc8jIzHasOdk--