From: Amit Shah <amit.shah@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/2] ram_find_and_save_block: Split out the finding
Date: Thu, 24 Sep 2015 09:27:21 +0530 [thread overview]
Message-ID: <20150924035721.GD25273@grmbl.mre> (raw)
In-Reply-To: <1443018431-11170-3-git-send-email-dgilbert@redhat.com>
On (Wed) 23 Sep 2015 [15:27:11], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Split out the finding of the dirty page and all the wrap detection
> into a separate function since it was getting a bit hairy.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> + if (pss->complete_round && pss->block == last_seen_block &&
> + pss->offset >= last_offset) {
> + /*
> + * We've been once around the RAM and haven't found anything
> + * give up.
I didn't notice this first time around - but I can fix this up while
merging. Give up should be another sentence, right?
Amit
next prev parent reply other threads:[~2015-09-24 3:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 14:27 [Qemu-devel] [PATCH v2 0/2] Split up ram_find_and_save_block Dr. David Alan Gilbert (git)
2015-09-23 14:27 ` [Qemu-devel] [PATCH v2 1/2] Move dirty page search state into separate structure Dr. David Alan Gilbert (git)
2015-09-23 14:27 ` [Qemu-devel] [PATCH v2 2/2] ram_find_and_save_block: Split out the finding Dr. David Alan Gilbert (git)
2015-09-24 3:57 ` Amit Shah [this message]
2015-09-24 3:56 ` [Qemu-devel] [PATCH v2 0/2] Split up ram_find_and_save_block Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150924035721.GD25273@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).