From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zexf5-0004Qq-PU for qemu-devel@nongnu.org; Wed, 23 Sep 2015 23:57:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zexf1-0004iL-NV for qemu-devel@nongnu.org; Wed, 23 Sep 2015 23:57:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zexf1-0004i2-Ik for qemu-devel@nongnu.org; Wed, 23 Sep 2015 23:57:31 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 383D18F30F for ; Thu, 24 Sep 2015 03:57:31 +0000 (UTC) Date: Thu, 24 Sep 2015 09:27:21 +0530 From: Amit Shah Message-ID: <20150924035721.GD25273@grmbl.mre> References: <1443018431-11170-1-git-send-email-dgilbert@redhat.com> <1443018431-11170-3-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443018431-11170-3-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 2/2] ram_find_and_save_block: Split out the finding List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: qemu-devel@nongnu.org, quintela@redhat.com On (Wed) 23 Sep 2015 [15:27:11], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Split out the finding of the dirty page and all the wrap detection > into a separate function since it was getting a bit hairy. > > Signed-off-by: Dr. David Alan Gilbert > + if (pss->complete_round && pss->block == last_seen_block && > + pss->offset >= last_offset) { > + /* > + * We've been once around the RAM and haven't found anything > + * give up. I didn't notice this first time around - but I can fix this up while merging. Give up should be another sentence, right? Amit