From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf2sD-00081b-3g for qemu-devel@nongnu.org; Thu, 24 Sep 2015 05:31:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zf2s7-0006LE-PD for qemu-devel@nongnu.org; Thu, 24 Sep 2015 05:31:29 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:37605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf2s7-0006JH-HS for qemu-devel@nongnu.org; Thu, 24 Sep 2015 05:31:23 -0400 Received: by wicfx3 with SMTP id fx3so104205260wic.0 for ; Thu, 24 Sep 2015 02:31:22 -0700 (PDT) Date: Thu, 24 Sep 2015 11:31:19 +0200 From: Eduardo Otubo Message-ID: <20150924093119.GA11859@vader> References: <1435756353-4150-1-git-send-email-drjones@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Content-Disposition: inline In-Reply-To: <1435756353-4150-1-git-send-email-drjones@redhat.com> Subject: Re: [Qemu-devel] [PATCH] libseccomp: add cacheflush to whitelist List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: pmoore@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org --envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 01, 2015 at 09=3D12=3D33AM -0400, Andrew Jones wrote: > cacheflush is an arm-specific syscall that qemu built for arm > uses. Add it to the whitelist. >=20 > Signed-off-by: Andrew Jones >=20 > --- >=20 > I'm not sure about the priority selection. Maybe cacheflush gets > used frequently enough that it deserves a higher one? The frequency is measured using strace and comparing the frequency they appear among other syscalls. Can you run this analysis and double check if the lowest priority is still accurate? Thanks for the patch. >=20 > This patch isn't really necessary yet due to ae6e8ef11e6c: "Revert > seccomp tests that allow it to be used on non-x86 architectures", > which we can't revert until libseccomp has released a fix for > arm-specific syscall symbol naming, but when linking to a patched > libseccomp and reverting ae6e8ef11e6c, then this patch allows > guests to boot with '-sandbox on'. >=20 > Signed-off-by: Andrew Jones > --- > qemu-seccomp.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/qemu-seccomp.c b/qemu-seccomp.c > index f9de0d3390feb..33644a4e3c3d3 100644 > --- a/qemu-seccomp.c > +++ b/qemu-seccomp.c > @@ -237,7 +237,8 @@ static const struct QemuSeccompSyscall seccomp_whitel= ist[] =3D { > { SCMP_SYS(fadvise64), 240 }, > { SCMP_SYS(inotify_init1), 240 }, > { SCMP_SYS(inotify_add_watch), 240 }, > - { SCMP_SYS(mbind), 240 } > + { SCMP_SYS(mbind), 240 }, > + { SCMP_SYS(cacheflush), 240 }, > }; > =20 > int seccomp_start(void) > --=20 > 2.1.0 >=20 --=20 Eduardo Otubo ProfitBricks GmbH --envbJBWh7q8WU6mo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWA8LnAAoJEP0M/1sS+L0vIc8IAMD9l5IwTd8q+EcH1xYtlQ9K 9d2bmdr/wtMDKutCPjO+xmdY9/ZtEz5VXHsu38pbgMocNA01aoWuT00vc06NfbqJ csnCMQuT4bl3fbXcPtSCiIbZZGxLJ7OxQPuZozVfx0Olgqh3VeAQcakrk+xa9EGw cDHHCkxAChTrS+ndpUbhnBiVfkquo+c9WXrKdQMex8HB9Q5zWQrHy5KK4myMK5q7 wg10zJwjJo4GpJwZlz7e4BNm4QjHR1HDeOGJFV59bYLr627OSBtsZ3fRtJb36Zwx Tx6r4UTgRULlhaHhb5QhKpUQBWttvNT0cWhWeUE/z1NXDfeXnBlhGcQbaszIQ3U= =vw3J -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo--