From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf1Se-0004zE-R1 for qemu-devel@nongnu.org; Thu, 24 Sep 2015 04:01:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zf1Sb-0001Nd-K1 for qemu-devel@nongnu.org; Thu, 24 Sep 2015 04:01:00 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:47163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf1Sb-0001Fg-B6 for qemu-devel@nongnu.org; Thu, 24 Sep 2015 04:00:57 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 24 Sep 2015 09:00:53 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 53B9F2190019 for ; Thu, 24 Sep 2015 09:00:21 +0100 (BST) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t8O80oOa31195150 for ; Thu, 24 Sep 2015 08:00:50 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t8O80oaH013008 for ; Thu, 24 Sep 2015 02:00:50 -0600 Date: Thu, 24 Sep 2015 10:00:46 +0200 From: Greg Kurz Message-ID: <20150924100046.1ea1d136@bahia.local> In-Reply-To: <20150921100934.3d2067d4@bahia.local> References: <20150918142446.17211.7965.stgit@bahia.huguette.org> <87oagybu99.fsf@linux.vnet.ibm.com> <20150921100934.3d2067d4@bahia.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-9p: migrate virtio subsections List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, "Aneesh Kumar K.V" On Mon, 21 Sep 2015 10:09:34 +0200 Greg Kurz wrote: > On Sat, 19 Sep 2015 15:34:02 +0530 > "Aneesh Kumar K.V" wrote: > > > Greg Kurz writes: > > > > > In a cross-endian setup, the virtio-9p device has state in @device_endian. It > > > must be migrated. > > > > > > Signed-off-by: Greg Kurz > > > > With 9p mounted, we don't support qemu migration. We have > > migration blocker added in v9fs_attach. > > > > Ok I should have been more precise... If you unmount the 9p share, then > migrate, then try to remount, you end up with a hung mount command because > @device_endian has the wrong value... > Michael ? Any input ? > > > --- > > > hw/9pfs/virtio-9p-device.c | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c > > > index 93a407c45926..e3abcfaffb2a 100644 > > > --- a/hw/9pfs/virtio-9p-device.c > > > +++ b/hw/9pfs/virtio-9p-device.c > > > @@ -43,6 +43,16 @@ static void virtio_9p_get_config(VirtIODevice *vdev, uint8_t *config) > > > g_free(cfg); > > > } > > > > > > +static void virtio_9p_save(QEMUFile *f, void *opaque) > > > +{ > > > + virtio_save(VIRTIO_DEVICE(opaque), f); > > > +} > > > + > > > +static int virtio_9p_load(QEMUFile *f, void *opaque, int version_id) > > > +{ > > > + return virtio_load(VIRTIO_DEVICE(opaque), f, version_id); > > > +} > > > + > > > static void virtio_9p_device_realize(DeviceState *dev, Error **errp) > > > { > > > VirtIODevice *vdev = VIRTIO_DEVICE(dev); > > > @@ -130,6 +140,7 @@ static void virtio_9p_device_realize(DeviceState *dev, Error **errp) > > > } > > > v9fs_path_free(&path); > > > > > > + register_savevm(dev, "virtio-9p", -1, 1, virtio_9p_save, virtio_9p_load, s); > > > return; > > > out: > > > g_free(s->ctx.fs_root); > >