From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53294)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1Zf4YZ-0004nT-Bm
	for qemu-devel@nongnu.org; Thu, 24 Sep 2015 07:19:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1Zf4YW-0005y7-2Y
	for qemu-devel@nongnu.org; Thu, 24 Sep 2015 07:19:19 -0400
Received: from mail-wi0-f172.google.com ([209.85.212.172]:38183)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shmulik.ladkani@ravellosystems.com>)
	id 1Zf4YV-0005xY-T8
	for qemu-devel@nongnu.org; Thu, 24 Sep 2015 07:19:16 -0400
Received: by wiclk2 with SMTP id lk2so108030620wic.1
	for <qemu-devel@nongnu.org>; Thu, 24 Sep 2015 04:19:15 -0700 (PDT)
Date: Thu, 24 Sep 2015 14:19:12 +0300
From: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Message-ID: <20150924141912.556ed664@pixies>
In-Reply-To: <20150903101919.628d67ff@pixies>
References: <1441210493-19591-1-git-send-email-stefanha@redhat.com>
	<1441210493-19591-7-git-send-email-stefanha@redhat.com>
	<20150903101919.628d67ff@pixies>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 6/7] vmxnet3: Drop
 net_vmxnet3_info.can_receive
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, qemu-stable <qemu-stable@nongnu.org>

Hi,

On Thu, 3 Sep 2015 10:19:19 +0300, shmulik.ladkani@ravellosystems.com wrote:
> On Wed,  2 Sep 2015 17:14:52 +0100, stefanha@redhat.com wrote:
> > From: Fam Zheng <famz@redhat.com>
> > 
> > Commit 6e99c63 ("net/socket: Drop net_socket_can_send") changed the
> > semantics around .can_receive for sockets to now require the device to
> > flush queued pkts when transitioning to a .can_receive=true state. But
> > it's OK to drop incoming packets when the link is not active.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> 
> Tested-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>

Ping...

I'm not sure what's the exact policy, but shouldn't
'2734a20 vmxnet3: Drop net_vmxnet3_info.can_receive' go into stable-2.4?

Otherwise, vmxnet3 has no rx connectivity in 2.4 based releases.

See here: 
https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02233.html

Regards,
Shmulik