From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf7sP-0000Gs-Al for qemu-devel@nongnu.org; Thu, 24 Sep 2015 10:52:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zf7sL-0000Vz-Jt for qemu-devel@nongnu.org; Thu, 24 Sep 2015 10:52:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf7sL-0000VP-FS for qemu-devel@nongnu.org; Thu, 24 Sep 2015 10:51:57 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 2B06FC0B91A9 for ; Thu, 24 Sep 2015 14:51:57 +0000 (UTC) Date: Thu, 24 Sep 2015 15:51:53 +0100 From: "Daniel P. Berrange" Message-ID: <20150924145153.GH31980@redhat.com> References: <1442582350-9179-1-git-send-email-berrange@redhat.com> <56014838.6020109@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <56014838.6020109@redhat.com> Subject: Re: [Qemu-devel] [PATCH v1 00/16] Introduce I/O channels framework Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Gerd Hoffmann , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" On Tue, Sep 22, 2015 at 02:23:20PM +0200, Paolo Bonzini wrote: > > > On 18/09/2015 15:18, Daniel P. Berrange wrote: > > David Gilbert had some feedback on my previous RFC series which > > I have incorporated into this new posting. I did forget his > > comments about using #defines instead of magic constants in > > the websock patch, so that's still on my todo list. > > > > Finally I've listed myself as maintainer for the new io/ and > > include/io/ directory prefixes. > > I only made a few very small remarks. The API is reasonable and you've > proved its utility by using it in the rest of your project. Thanks, I'd still love one or more people to do a detailed review of the I/O channel implementations before I think about sending a PULL request, since there's a fair amount of code in there.... > I remember I had some remarks about the rest of the conversion and > especially the integration with coroutines, but it's not part of this > series. I'm curious now as to which bit you might be refering to here :-) IIRC the only place I had any interaction with coroutines was the migration code QEMUFile implementation, where I need to yield when reads block. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|