From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfLoM-0005Hq-GT for qemu-devel@nongnu.org; Fri, 25 Sep 2015 01:44:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfLoL-0003qa-HC for qemu-devel@nongnu.org; Fri, 25 Sep 2015 01:44:46 -0400 Date: Fri, 25 Sep 2015 15:14:26 +1000 From: David Gibson Message-ID: <20150925051426.GA11620@voom.redhat.com> References: <1443069231-14856-1-git-send-email-david@gibson.dropbear.id.au> <1443069231-14856-2-git-send-email-david@gibson.dropbear.id.au> <1443110515.23936.553.camel@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline In-Reply-To: <1443110515.23936.553.camel@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/7] vfio: Remove unneeded union from VFIOContainer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: lvivier@redhat.com, thuth@redhat.com, abologna@redhat.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, pbonzini@redhat.com --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 24, 2015 at 10:01:55AM -0600, Alex Williamson wrote: > On Thu, 2015-09-24 at 14:33 +1000, David Gibson wrote: > > Currently the VFIOContainer iommu_data field contains a union with > > different information for different host iommu types. However: > > * It only actually contains information for the x86-like "Type1" iom= mu > > * Because we have a common listener the Type1 fields are actually us= ed > > on all IOMMU types, including the SPAPR TCE type as well > > * There's no tag in the VFIOContainer to tell you which union member= is > > valid anyway. >=20 > FWIW, this last point isn't valid. The IOMMU setup determines which > union member is active and the listener and release functions are > specific to the union member. There's no need whatsoever for a tag to > keep track of the union member in use. The only problem is that the > union solved a problem that never really came to exist, so we can now > remove it and simplify things. I could argue some of the details there, but none of them are really important. > I'll remove this last bullet point unless there's some objection. > Thanks, That's fine. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWBNgyAAoJEGw4ysog2bOSBXwP/1osuS77c70ink4OxBCihvrd 0exHu1SX5mJYgZof+xxuh0wJNxCkBRyIBxVN/AplcvVcJmQ0hhqLUd6O3dk0HqmO QdoPpDvuktqNf8G+/S8Hm9gkAx7JNCTg0w+XPYn77AcXNm9awItJB8oMc/iKVNSI dvZVE/SO25Ao1ua/13NudlAAfHjNc8PCIXzELjzKTIRCB6fFR/+NZzJlkOlZgTAs HchlnYdFtVLnG4F/LL1Wl31ycGsbzMb0+a/X5AdHVB+gYwYxyyLJHLauqFottZvs x4Zgb+z64oR0uS0A/Bi0IpATJ3itn7CAdxJY0vKSylbRRUrz3GkmoGQnzs6urqr+ wzNP+hmTGm7ZZeeUvLuRfuI/fJdce2PpH9wopzekQj+zT6qoqJKWZQ98xR+ijLiM EBmCi5zlMyftwVc/MOE2rFhG59sRRXOtpkIDuGUJXWpl5o7itJVE0f1jzx+WncpY kR81+ybY48hsdD4AFoVqje4lq23SPjIdgzMwsAsHA58q8d8fr4oqqaKXzkAWxg1S MFlMf8fhWvEOXqlSKPJGbQFq70qc4FvQJwreOiuHf7BktkOB4aoVxZb25UayQosk DTgh2lA8yffngfScbZ03x8G9O93RwLktHWeXhSXYOPyjZ027vSCBO9MJLkoYJYn3 7Z2lFoKVEtfFUsb1FOQm =1PpZ -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv--