From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33339)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZfUZQ-00031F-IZ
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:06:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZfUZM-00039Z-TC
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:05:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41838)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZfUZM-000379-No
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:05:52 -0400
Date: Fri, 25 Sep 2015 16:01:36 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20150925150136.GF13579@redhat.com>
References: <1443184788-18859-1-git-send-email-afaerber@suse.de>
	<1443184788-18859-5-git-send-email-afaerber@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1443184788-18859-5-git-send-email-afaerber@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 4/7] tests: Add QOM property unit tests
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, Bruce Rogers <brogers@suse.com>, Lin Ma <lma@suse.com>, Paolo Bonzini <pbonzini@redhat.com>

On Fri, Sep 25, 2015 at 02:39:45PM +0200, Andreas F=C3=A4rber wrote:
> Add a test for parsing and setting a uint64 property.
>=20
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> ---
>  MAINTAINERS             |   1 +
>  tests/Makefile          |   3 ++
>  tests/check-qom-props.c | 120 ++++++++++++++++++++++++++++++++++++++++=
++++++++
>  3 files changed, 124 insertions(+)
>  create mode 100644 tests/check-qom-props.c

FWIW, back in commit a31bdae5a76ecc060c1eb8a66be1896072c1e8b2 I added
a  check-qom-proplist.c unit test, and later extended it with test
for enums. Perhaps your addition is best placed in there, or we could
rename that test to check-qom-props.c so we just have one file for all
property unit testing

Regards,
Daniel
--=20
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange=
/ :|
|: http://libvirt.org              -o-             http://virt-manager.or=
g :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr=
/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vn=
c :|