From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgYOA-0006U6-FN for qemu-devel@nongnu.org; Mon, 28 Sep 2015 09:22:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZgYO7-0006Zu-DU for qemu-devel@nongnu.org; Mon, 28 Sep 2015 09:22:42 -0400 Received: from jessie.kos.to ([212.47.231.226]:45044 helo=pilvi.kos.to) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgYO7-0006Z9-7z for qemu-devel@nongnu.org; Mon, 28 Sep 2015 09:22:39 -0400 Date: Mon, 28 Sep 2015 16:22:37 +0300 From: Riku Voipio Message-ID: <20150928132237.GB20506@kos.to> References: <1436205821-20320-1-git-send-email-meadori@codesourcery.com> <1436205821-20320-2-git-send-email-meadori@codesourcery.com> <559ADA58.9020409@vivier.eu> <20150713200801.GA24071@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150713200801.GA24071@mentor.com> Subject: Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Meador Inge Cc: Laurent Vivier , qemu-devel@nongnu.org On Mon, Jul 13, 2015 at 01:08:02PM -0700, Meador Inge wrote: > On Mon, Jul 06, 2015 at 09:43:20PM +0200, Laurent Vivier wrote: > > > Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h > On second thought, I was following an existing pattern in 'main.c'. Really > fixing this would require changing around 30 other locations too. I think > if we are going to switch to the EXIT_* macros, then the whole file should > be changed in one patch and making that fix shouldn't hold this patch up. I've just done a commit to for wholesale transition. This code is only ever compiled for Linux, so portability doesn't matter. I think it makes the code a bit more self-documenting. Riku