From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47771) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zgnxg-0006sy-4H for qemu-devel@nongnu.org; Tue, 29 Sep 2015 02:00:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zgnxe-0003DX-Tp for qemu-devel@nongnu.org; Tue, 29 Sep 2015 02:00:24 -0400 Date: Tue, 29 Sep 2015 15:22:55 +1000 From: David Gibson Message-ID: <20150929052255.GN19428@voom.redhat.com> References: <1443082968-20440-1-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Zbynv6TNPa9FrOf6" Content-Disposition: inline In-Reply-To: <1443082968-20440-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH v1 0/2] spapr: Abort when HTAB size requirement can't be met List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: nfont@linux.vnet.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com --Zbynv6TNPa9FrOf6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 24, 2015 at 01:52:46PM +0530, Bharata B Rao wrote: > HTAB size is a factor of maximum memory size that is specified by maxmem= =3D > command line option. In cases where there is shortage of host memory, host > will not be able to allocate contiguous memory for guest HTAB and will > instead allocate a smaller HTAB. This usually is not a problem but when > user starts hotplugging memory to the guest, we can run out of HTAB entri= es > and hence memory hotplug fails. This failure should have been handled > gracefully by the guest kernel, but currently it leads to guest kernel OO= PS. > This will eventually get fixed when the handling of memory hotplug is > completely moved to kernel for PowerKVM. >=20 > Prevent such kernel failure by refusing to boot the guest when requested > HTAB size can't be allocated. However HTAB allocation happens in the > reset path from where it is too late to abort. Hence this patchset > moves the HTAB allocation to machine init and aborts if HTAB size > requirement isn't met. >=20 > This patchset applies against David Gibson's spapr-next. With this > patchset, simple boot, reboot and migration tests pass with HV KVM guest. > For PR KVM guest, boot and reboot tests were done since migration already > appears broken for PR KVM. This looks good. Applied to spapr-next --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --Zbynv6TNPa9FrOf6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWCiAvAAoJEGw4ysog2bOS920QAMHgVq/iyK5z7fIC5YZd9JXD nX+PIWCf1cQzwnwqHrN4eaqdFPxK0AZcRYURVgKTjVkhxJH6fTmkfGbeNKudvEfo s7QVAQvrJvimWsIj90ZK6StrnE70vDJKq5VLtBS2Uqpg5h/Ex4Zk0vRyy2RH3PC3 sWdwgrPM9F6WUz6a0Ut3he60ZwK0MiM4uZdxmTNsZ9si1OUVMjdeLMclBWBu43Ol B+gUoAlEeYC8Z6l5kjFkTMD7L4DtTAhENeHkIuP7j+LUhGJMOUsQf6JYoM8Lu34m ZaMaCS7P94i7MENTjw2vD+1y4XctB6VV8DSZYMLlzsJ12V6gnhBKRDC9VHqay11e N+6pYYBP8dht7aX1ILX86Nk3LytSg0GptpSbuaAPliJJ4PTM5VpI37isLCaFaoNH C6TuuKssH/32gtPfh8Y4hRywhsKfEq8paYyFw7Vd7onbra97GhF6smZaPDpX9Lk+ T/m0YM4xv5fXN1KFSArIS6VuM6dZ0Gm75/SVeMedwhIDDJR/UfiWa5lMZj4aETgv /Y+1HzL7z+vNhHJ4oj3pwR0RWrBRHRxfB1gYVGfruaqUOikV4BTob/a4+eTn35EI 9/saWwk6a2Wbzdml5Y1D4A8OOmxM6lOcmlkQ8FF2uLUiGRNpuIg9+OsJ6nBTkfQy rAViWRfQ3eTEu4EbBfHz =9zEi -----END PGP SIGNATURE----- --Zbynv6TNPa9FrOf6--