From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zgx8J-0000PT-NF for qemu-devel@nongnu.org; Tue, 29 Sep 2015 11:48:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zgx8G-0008WT-V4 for qemu-devel@nongnu.org; Tue, 29 Sep 2015 11:47:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zgx8G-0008Vw-QA for qemu-devel@nongnu.org; Tue, 29 Sep 2015 11:47:56 -0400 Date: Tue, 29 Sep 2015 17:47:52 +0200 From: Andrew Jones Message-ID: <20150929154752.GA21067@hawk.localdomain> References: <1443539307-20690-1-git-send-email-cov@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443539307-20690-1-git-send-email-cov@codeaurora.org> Subject: Re: [Qemu-devel] [PATCH] kvm-unit-tests: arm: Fail on unknown subtest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christopher Covington Cc: qemu-devel@nongnu.org On Tue, Sep 29, 2015 at 11:08:27AM -0400, Christopher Covington wrote: > Signed-off-by: Christopher Covington > --- > arm/selftest.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arm/selftest.c b/arm/selftest.c > index fc9ec60..aa16a91 100644 > --- a/arm/selftest.c > +++ b/arm/selftest.c > @@ -376,6 +376,8 @@ int main(int argc, char **argv) > cpumask_set_cpu(0, &smp_reported); > while (!cpumask_full(&smp_reported)) > cpu_relax(); > + } else { > + report("Unknown subtest", false); I think printf("Unknown subtest\n"); abort(); might be better. Also, please post kvm-unit-tests patches to the kvm mailing list. Thanks, drew > } > > return report_summary(); > -- > Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >