From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zgvq5-0000Yq-Tg for qemu-devel@nongnu.org; Tue, 29 Sep 2015 10:25:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zgvq1-0005rG-Lo for qemu-devel@nongnu.org; Tue, 29 Sep 2015 10:25:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zgvgs-0001oj-7w for qemu-devel@nongnu.org; Tue, 29 Sep 2015 10:15:34 -0400 Date: Tue, 29 Sep 2015 17:15:25 +0300 From: "Michael S. Tsirkin" Message-ID: <20150929171458-mutt-send-email-mst@redhat.com> References: <1443389342-2186-1-git-send-email-somlo@cmu.edu> <20150929132638-mutt-send-email-mst@redhat.com> <560A9940.3060207@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <560A9940.3060207@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 0/5] add ACPI node for fw_cfg on pc and arm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: peter.maydell@linaro.org, drjones@redhat.com, matt.fleming@intel.com, ehabkost@redhat.com, ard.biesheuvel@linaro.org, "Gabriel L. Somlo" , zhaoshenglong@huawei.com, qemu-devel@nongnu.org, leif.lindholm@linaro.org, kevin@koconnor.net, kraxel@redhat.com, pbonzini@redhat.com, imammedo@redhat.com, markmb@redhat.com, rth@twiddle.net On Tue, Sep 29, 2015 at 03:59:28PM +0200, Laszlo Ersek wrote: > On 09/29/15 12:27, Michael S. Tsirkin wrote: > > On Sun, Sep 27, 2015 at 05:28:57PM -0400, Gabriel L. Somlo wrote: > >> New since v3: > >> > >> - rebased to work on top of 87e896ab (introducing pc-*-25 classes), > >> inserting fw_cfg acpi node only for machines >=3D 2.5. > >> > >> - reintroduce _STA with value 0x0B (bit 2 for u/i visibility turned > >> off to avoid Windows complaining -- thanks Igor for catching that= !) > >> > >> If there's any other feedback besides questions regarding the > >> appropriateness of "QEMU0002" as the value of _HID, please don't hes= itate! > >> > >> Thanks much, > >> --Gabriel > >=20 > > How does /proc/ioports look before and after this patch? >=20 > ... I vaguely remember that /proc/ioports and /proc/iomem tracks only > actual allocations by drivers. So the driver is supposed to get the > resources from ACPI, but until a driver actually allocates the ports (I > fail to recall the exact Linux APIs ATM -- apologies), the registers > might not show up in these pseudo-files. >=20 > OTOH Gabriel is working on a guest kernel driver that would look at ACP= I > I think... >=20 > Laszlo What does the driver do? I hope it doesn't poke at _CRS ... > >=20 > >=20 > >>> New since v2: > >>> > >>> - pc/i386 node in ssdt only on machine types *newer* than 2.4 > >>> (as suggested by Eduardo) > >>> > >>> I appreciate any further comments and reviews. Hopefully we can mak= e > >>> this palatable for upstream, modulo the lingering concerns about wh= ether > >>> "QEMU0002" is ok to use as the value of _HID, which I'll hopefully = get > >>> sorted out with the kernel crew... > >>> > >>>> New since v1: > >>>> > >>>> - expose control register size (suggested by Marc Mar=ED) > >>>> > >>>> - leaving out _UID and _STA fields (thanks Shannon & Igor) > >>>> > >>>> - using "QEMU0002" as the value of _HID (thanks Michael) > >>>> > >>>> - added documentation blurb to docs/specs/fw_cfg.txt > >>>> (mainly to record usage of the "QEMU0002" string with fw_cfg). > >>>> > >>>>> This series adds a fw_cfg device node to the SSDT (on pc), or to = the > >>>>> DSDT (on arm). > >>>>> > >>>>> - Patch 1/3 moves (and renames) the BIOS_CFG_IOPORT (0x510) > >>>>> define from pc.c to pc.h, so that it could be used from > >>>>> acpi-build.c in patch 2/3. > >>>>> > >>>>> - Patch 2/3 adds a fw_cfg node to the pc SSDT. > >>>>> > >>>>> - Patch 3/3 adds a fw_cfg node to the arm DSDT. > >>>>> > >>>>> I made up some names - "FWCF" for the node name, and "FWCF0001" > >>>>> for _HID; no idea whether that's appropriate, or how else I shoul= d > >>>>> figure out what to use instead... > >>>>> > >>>>> Also, using scope "\\_SB", based on where fw_cfg shows up in the > >>>>> output of "info qtree". Again, if that's wrong, please point me i= n > >>>>> the right direction. > >>>>> > >>>>> Re. 3/3 (also mentioned after the commit blurb in the patch itsel= f), > >>>>> I noticed none of the other DSDT entries contain a _STA field, wo= ndering > >>>>> why it would (not) make sense to include that, same as on the PC. > >> > >> Gabriel L. Somlo (5): > >> fw_cfg: expose control register size in fw_cfg.h > >> pc: fw_cfg: move ioport base constant to pc.h > >> acpi: pc: add fw_cfg device node to ssdt > >> acpi: arm: add fw_cfg device node to dsdt > >> fw_cfg: document ACPI device node information > >> > >> docs/specs/fw_cfg.txt | 9 +++++++++ > >> hw/arm/virt-acpi-build.c | 15 +++++++++++++++ > >> hw/i386/acpi-build.c | 23 +++++++++++++++++++++++ > >> hw/i386/pc.c | 5 ++--- > >> hw/i386/pc_piix.c | 1 + > >> hw/i386/pc_q35.c | 1 + > >> hw/nvram/fw_cfg.c | 8 +++++--- > >> include/hw/i386/pc.h | 3 +++ > >> include/hw/nvram/fw_cfg.h | 3 +++ > >> 9 files changed, 62 insertions(+), 6 deletions(-) > >> > >> --=20 > >> 2.4.3