From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zh6vS-0003uO-PO for qemu-devel@nongnu.org; Tue, 29 Sep 2015 22:15:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zh6vR-0004JH-Lk for qemu-devel@nongnu.org; Tue, 29 Sep 2015 22:15:22 -0400 Date: Wed, 30 Sep 2015 12:15:43 +1000 From: David Gibson Message-ID: <20150930021543.GC13035@voom.fritz.box> References: <1443069231-14856-1-git-send-email-david@gibson.dropbear.id.au> <1443069231-14856-6-git-send-email-david@gibson.dropbear.id.au> <56052DEC.6040500@redhat.com> <20150925113349.GL11620@voom.redhat.com> <5605383E.1090406@redhat.com> <20150926065414.GM11620@voom.redhat.com> <56090157.2000903@redhat.com> <20150929033033.GA19428@voom.redhat.com> <560A3AAE.7070005@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hOcCNbCCxyk/YU74" Content-Disposition: inline In-Reply-To: <560A3AAE.7070005@redhat.com> Subject: Re: [Qemu-devel] [PATCH 5/7] memory: Allow replay of IOMMU mapping notifications List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, abologna@redhat.com, alex.williamson@redhat.com, qemu-ppc@nongnu.org --hOcCNbCCxyk/YU74 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 29, 2015 at 09:15:58AM +0200, Paolo Bonzini wrote: >=20 >=20 > On 29/09/2015 05:30, David Gibson wrote: > >> Maybe... The only issue is the "granularity" argument, which is=20 > >> not in memory_region_register_iommu_notifier. That makes me > >> wonder if the replay and registration make sense as separate > >> operations. > >>=20 > >> What about adding a new function memory_region_iommu_replay and=20 > >> separate the two phases? > >=20 > > Hm.. I'm not sure I see much advantage to separating the phases. >=20 > It's just that it's (IMO) the clearest API. It shows how the > granularity is only used for replay. >=20 > > But I don't particularly object to the idea either. So, I think > it's your > > call. >=20 > Yes, let's separate it. Ok, I've done that, and sent a hopefull final respin of the series. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --hOcCNbCCxyk/YU74 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWC0XPAAoJEGw4ysog2bOSbP8P/iFRknJvjJcSmNkSznHrMVA/ XMhQMAVwK9ZNT3kZ1fO5uToBO2cYmvAMZG63C+a/EFKxzqqsVHLLEjB1/p7PkVUP rCQwnn25Q6Gim1a+ZOcFFwMF9cLOlycIS5EGYG1zoofrK0+jaa8+9HAgt5TDYCBO mGYSuZSA91prWUcafD6fUffjAq8vZbXdKUFt7xn98I5ukoURI3gUAo9jsvB6uIXY txiNwJLhCS33CgGCJKNC4bsIpcuEhTQkTJFHBUPS3uiNybGtHqMPDcBw4Ww2oZSi HnmXbvvLaNyd2RsGtyN5OqviR7CJ7pCHs3gjE6Jlgy0R1weHbEQsVoqWKyj2LC3e 81JQd5fxuypb+Hidd5e/8QoZ7TZ43zgrulRZOuXP/b2nyQ+yTt23SkqRvySxchiu vP7kSwOtg+h+iTLNO2jgxLWlyXmaIfeBtUxza+wdIZAqwHXQljIDpjPQnVQyrSRR aovQCtsjcYrZgvBEi+tEgdfJo99dhMnmx/LtPIXTvfsOBK/WHh164ZeRx4/Fdlkt 2MinqbsOXwj0uNEC4Px3HNd+t1WcvFyFfExIegkR/bCUH6t10Jp3IWFwtRMxxi16 2PvVS/XyhA8AI5ImajZT7a4q2OdDAgq0x+QCjAgrI1nadxtJtLD587dNLB49zQxy 8x/j1Im3WctbOmvmFvbb =KKAt -----END PGP SIGNATURE----- --hOcCNbCCxyk/YU74--