From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54209) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhQpP-0000xj-4L for qemu-devel@nongnu.org; Wed, 30 Sep 2015 19:30:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhQpJ-0002DY-TW for qemu-devel@nongnu.org; Wed, 30 Sep 2015 19:30:26 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:32201 helo=imgpgp01.kl.imgtec.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhQpJ-0002DE-MK for qemu-devel@nongnu.org; Wed, 30 Sep 2015 19:30:21 -0400 Date: Thu, 1 Oct 2015 00:30:19 +0100 From: James Hogan Message-ID: <20150930233019.GD23982@jhogan-linux.le.imgtec.org> References: <1443627027-2193-1-git-send-email-james.hogan@imgtec.com> <1443627027-2193-6-git-send-email-james.hogan@imgtec.com> <560C6F21.5090503@twiddle.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sXc4Kmr5FA7axrvy" Content-Disposition: inline In-Reply-To: <560C6F21.5090503@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 5/7] tcg/mips: Support r6 multiply/divide encodings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Leon Alrae , qemu-devel@nongnu.org, Aurelien Jarno --sXc4Kmr5FA7axrvy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 01, 2015 at 09:24:17AM +1000, Richard Henderson wrote: > On 10/01/2015 01:30 AM, James Hogan wrote: > > case INDEX_op_mul_i32: > > + if (use_mips32r6_instructions) { > > + tcg_out_opc_reg(s, OPC_MUL_R6, a0, a1, a2); > > + break; > > + } > > if (use_mips32_instructions) { > > tcg_out_opc_reg(s, OPC_MUL, a0, a1, a2); > > break; >=20 > I wonder if it's worth defining a common OPC_MUL as you did with OPC_JR. Yes, probably would make sense for these changed instruction encodings (rather than new instructions). > Also, these columns aren't lining up. Did you use tabs? Whitespace looks okay to me. Has your email client changed it? Thanks James --sXc4Kmr5FA7axrvy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWDHCLAAoJEGwLaZPeOHZ6cJQP/1fZn74ZkBQG/RqAUw/RFek2 S9c9u2jyHyDwr8tDXwIpU//AiveBIF/jnHNWaUXSkyO6szYDJ6SfZTbj/7mhJcpC 7SKWr/pumX904Kokn/awICkwa+8voeMcS/nyIJ5UkIDq9qsy6skemNqDnwU6kUlF Ml+PQOeZmXxfpKSd8ztL+jLd4x16/dgfIo5XdncKMzpCdUbSrKJw2hF7hhYbJZD1 +g+fNwESvDsx/20n2zVEI36IcfcUt3uD3J393kR9R3NxDDUjDPFMCZMyGUc/e5z/ 8ZqXq0AZi2NIu/3OmaG6uK9T2HQZ5yYaoHlejpheDnezVMW2cYe5SmoOPPzBkBA2 ThKhOXH6RGqKAQlekS1Ghbyb7+/t+mFlLgkF9lrqx9g4zzC7QACwTc9fv78RFWEw 723b8Mm7qsrZso24dlzMCuonvLhC9tVPNfdxZRU2u749WHoPZJaH6ZdyTg4ytIKh 3n5V7TZU7RiUrM9iUu6LltSdP4PKkT5Pa3iS6GHqyZQsAtm7u9t8hkoVPS6A07hU OkrrFMTF5tMTSgVCqsFF5Mf7U35dNe9gK9Y6afcLsLLoOKwvUC1KeeJ6gooGZWmp j1sacd6zPo/L7LZ6IF8TRwtZmExiOSNLX5i9T0rseHRAOhgim6uhrpuNJQIMzf5h 2x1+eGumSQpkC1V1kygN =Disi -----END PGP SIGNATURE----- --sXc4Kmr5FA7axrvy--