* [Qemu-devel] [PATCH] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command
@ 2015-09-18 5:55 Shmulik Ladkani
2015-09-18 9:11 ` Dmitry Fleytman
2015-10-01 7:00 ` Shmulik Ladkani
0 siblings, 2 replies; 4+ messages in thread
From: Shmulik Ladkani @ 2015-09-18 5:55 UTC (permalink / raw)
To: qemu-devel, Dmitry Fleytman, Stefan Hajnoczi
Cc: idan.brown, Dana Rubin, Shmulik Ladkani
Some drivers (e.g. vmware-tools) issue the VMXNET3_CMD_GET_ADAPTIVE_RING_INFO
command.
Currently, due to lack of support, a bogus value (-1) is returned.
Support this command, returning the "adaptive-ring disabled" flag.
Signed-off-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
---
hw/net/vmxnet3.c | 9 +++++++++
hw/net/vmxnet3.h | 6 +++++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 04159c8..56a1faa 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -1629,6 +1629,11 @@ static void vmxnet3_handle_command(VMXNET3State *s, uint64_t cmd)
VMW_CBPRN("Set: VMXNET3_CMD_GET_CONF_INTR - interrupt configuration");
break;
+ case VMXNET3_CMD_GET_ADAPTIVE_RING_INFO:
+ VMW_CBPRN("Set: VMXNET3_CMD_GET_ADAPTIVE_RING_INFO - "
+ "adaptive ring info flags");
+ break;
+
default:
VMW_CBPRN("Received unknown command: %" PRIx64, cmd);
break;
@@ -1668,6 +1673,10 @@ static uint64_t vmxnet3_get_command_status(VMXNET3State *s)
ret = vmxnet3_get_interrupt_config(s);
break;
+ case VMXNET3_CMD_GET_ADAPTIVE_RING_INFO:
+ ret = VMXNET3_DISABLE_ADAPTIVE_RING;
+ break;
+
default:
VMW_WRPRN("Received request for unknown command: %x", s->last_command);
ret = -1;
diff --git a/hw/net/vmxnet3.h b/hw/net/vmxnet3.h
index f987d71..f7006af 100644
--- a/hw/net/vmxnet3.h
+++ b/hw/net/vmxnet3.h
@@ -198,9 +198,13 @@ enum {
VMXNET3_CMD_GET_DID_LO, /* 0xF00D0005 */
VMXNET3_CMD_GET_DID_HI, /* 0xF00D0006 */
VMXNET3_CMD_GET_DEV_EXTRA_INFO, /* 0xF00D0007 */
- VMXNET3_CMD_GET_CONF_INTR /* 0xF00D0008 */
+ VMXNET3_CMD_GET_CONF_INTR, /* 0xF00D0008 */
+ VMXNET3_CMD_GET_ADAPTIVE_RING_INFO /* 0xF00D0009 */
};
+/* Adaptive Ring Info Flags */
+#define VMXNET3_DISABLE_ADAPTIVE_RING 1
+
/*
* Little Endian layout of bitfields -
* Byte 0 : 7.....len.....0
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command
2015-09-18 5:55 [Qemu-devel] [PATCH] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command Shmulik Ladkani
@ 2015-09-18 9:11 ` Dmitry Fleytman
2015-10-01 7:00 ` Shmulik Ladkani
1 sibling, 0 replies; 4+ messages in thread
From: Dmitry Fleytman @ 2015-09-18 9:11 UTC (permalink / raw)
To: Shmulik Ladkani; +Cc: Stefan Hajnoczi, idan.brown, qemu-devel, Dana Rubin
ACK.
> On Sep 18, 2015, at 08:55 AM, Shmulik Ladkani <shmulik.ladkani@ravellosystems.com> wrote:
>
> Some drivers (e.g. vmware-tools) issue the VMXNET3_CMD_GET_ADAPTIVE_RING_INFO
> command.
>
> Currently, due to lack of support, a bogus value (-1) is returned.
>
> Support this command, returning the "adaptive-ring disabled" flag.
>
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
> ---
> hw/net/vmxnet3.c | 9 +++++++++
> hw/net/vmxnet3.h | 6 +++++-
> 2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
> index 04159c8..56a1faa 100644
> --- a/hw/net/vmxnet3.c
> +++ b/hw/net/vmxnet3.c
> @@ -1629,6 +1629,11 @@ static void vmxnet3_handle_command(VMXNET3State *s, uint64_t cmd)
> VMW_CBPRN("Set: VMXNET3_CMD_GET_CONF_INTR - interrupt configuration");
> break;
>
> + case VMXNET3_CMD_GET_ADAPTIVE_RING_INFO:
> + VMW_CBPRN("Set: VMXNET3_CMD_GET_ADAPTIVE_RING_INFO - "
> + "adaptive ring info flags");
> + break;
> +
> default:
> VMW_CBPRN("Received unknown command: %" PRIx64, cmd);
> break;
> @@ -1668,6 +1673,10 @@ static uint64_t vmxnet3_get_command_status(VMXNET3State *s)
> ret = vmxnet3_get_interrupt_config(s);
> break;
>
> + case VMXNET3_CMD_GET_ADAPTIVE_RING_INFO:
> + ret = VMXNET3_DISABLE_ADAPTIVE_RING;
> + break;
> +
> default:
> VMW_WRPRN("Received request for unknown command: %x", s->last_command);
> ret = -1;
> diff --git a/hw/net/vmxnet3.h b/hw/net/vmxnet3.h
> index f987d71..f7006af 100644
> --- a/hw/net/vmxnet3.h
> +++ b/hw/net/vmxnet3.h
> @@ -198,9 +198,13 @@ enum {
> VMXNET3_CMD_GET_DID_LO, /* 0xF00D0005 */
> VMXNET3_CMD_GET_DID_HI, /* 0xF00D0006 */
> VMXNET3_CMD_GET_DEV_EXTRA_INFO, /* 0xF00D0007 */
> - VMXNET3_CMD_GET_CONF_INTR /* 0xF00D0008 */
> + VMXNET3_CMD_GET_CONF_INTR, /* 0xF00D0008 */
> + VMXNET3_CMD_GET_ADAPTIVE_RING_INFO /* 0xF00D0009 */
> };
>
> +/* Adaptive Ring Info Flags */
> +#define VMXNET3_DISABLE_ADAPTIVE_RING 1
> +
> /*
> * Little Endian layout of bitfields -
> * Byte 0 : 7.....len.....0
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command
2015-09-18 5:55 [Qemu-devel] [PATCH] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command Shmulik Ladkani
2015-09-18 9:11 ` Dmitry Fleytman
@ 2015-10-01 7:00 ` Shmulik Ladkani
2015-10-10 2:15 ` Jason Wang
1 sibling, 1 reply; 4+ messages in thread
From: Shmulik Ladkani @ 2015-10-01 7:00 UTC (permalink / raw)
To: qemu-devel, Jason Wang
Cc: Dmitry Fleytman, Stefan Hajnoczi, idan.brown, Dana Rubin
Ping...
On Fri, 18 Sep 2015 08:55:04 +0300, shmulik.ladkani@ravellosystems.com wrote:
> Some drivers (e.g. vmware-tools) issue the VMXNET3_CMD_GET_ADAPTIVE_RING_INFO
> command.
>
> Currently, due to lack of support, a bogus value (-1) is returned.
>
> Support this command, returning the "adaptive-ring disabled" flag.
>
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
> ---
> hw/net/vmxnet3.c | 9 +++++++++
> hw/net/vmxnet3.h | 6 +++++-
> 2 files changed, 14 insertions(+), 1 deletion(-)
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command
2015-10-01 7:00 ` Shmulik Ladkani
@ 2015-10-10 2:15 ` Jason Wang
0 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2015-10-10 2:15 UTC (permalink / raw)
To: Shmulik Ladkani, qemu-devel
Cc: Dmitry Fleytman, Stefan Hajnoczi, idan.brown, Dana Rubin
On 10/01/2015 03:00 PM, Shmulik Ladkani wrote:
> Ping...
>
> On Fri, 18 Sep 2015 08:55:04 +0300, shmulik.ladkani@ravellosystems.com wrote:
>> Some drivers (e.g. vmware-tools) issue the VMXNET3_CMD_GET_ADAPTIVE_RING_INFO
>> command.
>>
>> Currently, due to lack of support, a bogus value (-1) is returned.
>>
>> Support this command, returning the "adaptive-ring disabled" flag.
>>
>> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
>> ---
>> hw/net/vmxnet3.c | 9 +++++++++
>> hw/net/vmxnet3.h | 6 +++++-
>> 2 files changed, 14 insertions(+), 1 deletion(-)
> Thanks.
>
Applied in my tree.
https://github.com/jasowang/qemu/commits/net
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-10 2:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-18 5:55 [Qemu-devel] [PATCH] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command Shmulik Ladkani
2015-09-18 9:11 ` Dmitry Fleytman
2015-10-01 7:00 ` Shmulik Ladkani
2015-10-10 2:15 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).