* [Qemu-devel] [PATCH] kvm-unit-tests: arm: Fail on unknown subtest
@ 2015-09-29 15:08 Christopher Covington
2015-09-29 15:47 ` Andrew Jones
0 siblings, 1 reply; 4+ messages in thread
From: Christopher Covington @ 2015-09-29 15:08 UTC (permalink / raw)
To: drjones, qemu-devel; +Cc: Christopher Covington
Signed-off-by: Christopher Covington <cov@codeaurora.org>
---
arm/selftest.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arm/selftest.c b/arm/selftest.c
index fc9ec60..aa16a91 100644
--- a/arm/selftest.c
+++ b/arm/selftest.c
@@ -376,6 +376,8 @@ int main(int argc, char **argv)
cpumask_set_cpu(0, &smp_reported);
while (!cpumask_full(&smp_reported))
cpu_relax();
+ } else {
+ report("Unknown subtest", false);
}
return report_summary();
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] kvm-unit-tests: arm: Fail on unknown subtest
2015-09-29 15:08 [Qemu-devel] [PATCH] kvm-unit-tests: arm: Fail on unknown subtest Christopher Covington
@ 2015-09-29 15:47 ` Andrew Jones
2015-10-01 19:46 ` [Qemu-devel] [PATCHv2] " Christopher Covington
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Jones @ 2015-09-29 15:47 UTC (permalink / raw)
To: Christopher Covington; +Cc: qemu-devel
On Tue, Sep 29, 2015 at 11:08:27AM -0400, Christopher Covington wrote:
> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> ---
> arm/selftest.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arm/selftest.c b/arm/selftest.c
> index fc9ec60..aa16a91 100644
> --- a/arm/selftest.c
> +++ b/arm/selftest.c
> @@ -376,6 +376,8 @@ int main(int argc, char **argv)
> cpumask_set_cpu(0, &smp_reported);
> while (!cpumask_full(&smp_reported))
> cpu_relax();
> + } else {
> + report("Unknown subtest", false);
I think
printf("Unknown subtest\n");
abort();
might be better. Also, please post kvm-unit-tests patches to the
kvm mailing list.
Thanks,
drew
> }
>
> return report_summary();
> --
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCHv2] arm: Fail on unknown subtest
2015-09-29 15:47 ` Andrew Jones
@ 2015-10-01 19:46 ` Christopher Covington
2015-10-02 9:21 ` Andrew Jones
0 siblings, 1 reply; 4+ messages in thread
From: Christopher Covington @ 2015-10-01 19:46 UTC (permalink / raw)
To: drjones, qemu-devel, kvm, kvmarm; +Cc: Christopher Covington
Signed-off-by: Christopher Covington <cov@codeaurora.org>
---
arm/selftest.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arm/selftest.c b/arm/selftest.c
index fc9ec60..f4a5030 100644
--- a/arm/selftest.c
+++ b/arm/selftest.c
@@ -376,6 +376,9 @@ int main(int argc, char **argv)
cpumask_set_cpu(0, &smp_reported);
while (!cpumask_full(&smp_reported))
cpu_relax();
+ } else {
+ printf("Unknown subtest\n");
+ abort();
}
return report_summary();
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCHv2] arm: Fail on unknown subtest
2015-10-01 19:46 ` [Qemu-devel] [PATCHv2] " Christopher Covington
@ 2015-10-02 9:21 ` Andrew Jones
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Jones @ 2015-10-02 9:21 UTC (permalink / raw)
To: Christopher Covington; +Cc: pbonzini, qemu-devel, kvm, kvmarm
On Thu, Oct 01, 2015 at 03:46:25PM -0400, Christopher Covington wrote:
> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> ---
> arm/selftest.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arm/selftest.c b/arm/selftest.c
> index fc9ec60..f4a5030 100644
> --- a/arm/selftest.c
> +++ b/arm/selftest.c
> @@ -376,6 +376,9 @@ int main(int argc, char **argv)
> cpumask_set_cpu(0, &smp_reported);
> while (!cpumask_full(&smp_reported))
> cpu_relax();
> + } else {
> + printf("Unknown subtest\n");
> + abort();
> }
>
> return report_summary();
> --
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
>
Reviewed-by: Andrew Jones <drjones@redhat.com>
and applied to https://github.com/rhdrjones/kvm-unit-tests/tree/staging
Thanks,
drew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-02 9:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-29 15:08 [Qemu-devel] [PATCH] kvm-unit-tests: arm: Fail on unknown subtest Christopher Covington
2015-09-29 15:47 ` Andrew Jones
2015-10-01 19:46 ` [Qemu-devel] [PATCHv2] " Christopher Covington
2015-10-02 9:21 ` Andrew Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).