From: James Hogan <james.hogan@imgtec.com>
To: Leon Alrae <leon.alrae@imgtec.com>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2 2/6] disas/mips: Add R6 jr/jr.hb to disassembler
Date: Fri, 2 Oct 2015 10:22:31 +0100 [thread overview]
Message-ID: <20151002092230.GN23982@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <560E4C0F.2000304@imgtec.com>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
On Fri, Oct 02, 2015 at 10:19:11AM +0100, Leon Alrae wrote:
> On 01/10/15 11:58, James Hogan wrote:
> > @@ -2420,9 +2420,11 @@ const struct mips_opcode mips_builtin_opcodes[] =
> > {"hibernate","", 0x42000023, 0xffffffff, 0, 0, V1 },
> > {"ins", "t,r,+A,+B", 0x7c000004, 0xfc00003f, WR_t|RD_s, 0, I33 },
> > {"jr", "s", 0x00000008, 0xfc1fffff, UBD|RD_s, 0, I1 },
> > +{"jr", "s", 0x00000009, 0xfc1fffff, UBD|RD_s, 0, I32R6 }, /* jalr */
> > /* jr.hb is officially MIPS{32,64}R2, but it works on R1 as jr with
> > the same hazard barrier effect. */
> > {"jr.hb", "s", 0x00000408, 0xfc1fffff, UBD|RD_s, 0, I32 },
> > +{"jr.hb", "s", 0x00000408, 0xfc1fffff, UBD|RD_s, 0, I32R6 }, /* jalr.hb */
>
> jr.hb match should be 0x00000409, otherwise:
>
> Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
>
Whoops, well spotted, thanks Leon!
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-02 9:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 10:58 [Qemu-devel] [PATCH v2 0/6] tcg/mips: Minimal R6 support James Hogan
2015-10-01 10:58 ` [Qemu-devel] [PATCH v2 1/6] tcg-opc.h: Simplify debug_insn_start def James Hogan
2015-10-01 10:58 ` [Qemu-devel] [PATCH v2 2/6] disas/mips: Add R6 jr/jr.hb to disassembler James Hogan
2015-10-01 19:42 ` Richard Henderson
2015-10-02 9:19 ` Leon Alrae
2015-10-02 9:22 ` James Hogan [this message]
2015-10-01 10:58 ` [Qemu-devel] [PATCH v2 3/6] tcg/mips: Add use_mips32r6_instructions definition James Hogan
2015-10-01 10:58 ` [Qemu-devel] [PATCH v2 4/6] tcg/mips: Support r6 JR encoding James Hogan
2015-10-01 10:58 ` [Qemu-devel] [PATCH v2 5/6] tcg/mips: Support r6 multiply/divide encodings James Hogan
2015-10-01 19:40 ` Richard Henderson
2015-10-01 10:58 ` [Qemu-devel] [PATCH v2 6/6] tcg/mips: Support r6 SEL{NE, EQ}Z instead of MOVN/MOVZ James Hogan
2015-10-01 19:53 ` Richard Henderson
2015-10-02 9:31 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002092230.GN23982@jhogan-linux.le.imgtec.org \
--to=james.hogan@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=leon.alrae@imgtec.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).