From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhzoT-00070C-Qf for qemu-devel@nongnu.org; Fri, 02 Oct 2015 08:51:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhzoQ-0003Ti-Dn for qemu-devel@nongnu.org; Fri, 02 Oct 2015 08:51:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhzoQ-0003TZ-0W for qemu-devel@nongnu.org; Fri, 02 Oct 2015 08:51:46 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id A937985545 for ; Fri, 2 Oct 2015 12:51:45 +0000 (UTC) Date: Fri, 2 Oct 2015 14:51:43 +0200 From: Kashyap Chamarthy Message-ID: <20151002125143.GA26385@tesla.redhat.com> References: <1443787955-19823-1-git-send-email-kchamart@redhat.com> <560E7B3C.2080905@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <560E7B3C.2080905@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qmp-commands.hx: Update the supported 'transaction' operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, jsnow@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com On Fri, Oct 02, 2015 at 06:40:28AM -0600, Eric Blake wrote: > On 10/02/2015 06:12 AM, Kashyap Chamarthy wrote: > > Although the canonical source of reference for QMP commands is > > qapi-schema.json, for consistency's sake, update qmp-commands.hx to > > state the list of supported transactionable operations, namely: > > > > drive-backup > > blockdev-backup > > blockdev-snapshot-internal-sync > > abort > > block-dirty-bitmap-add > > block-dirty-bitmap-clear > > > > Also update the possible values for the "type" action array. > > > > Signed-off-by: Kashyap Chamarthy > > Reviewed-by: Eric Blake > > Significant enough changes that I would have dropped R-b before posting > to ensure it gets looked at. Yes, I was wary of this and thought I included a blurb "Removing Eric's R-b as this change involves more edits." My bad, seems to have missed it while message composition. And, your reminder doesn't hurt. > But fortunately, you did a good job, so you can still keep my R-b. Thanks. -- /kashyap