From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51400)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1Zi0XH-00040K-7y
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 09:38:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1Zi0XD-0004cs-VL
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 09:38:07 -0400
Received: from mail-qg0-f54.google.com ([209.85.192.54]:34505)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1Zi0XD-0004cf-RB
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 09:38:03 -0400
Received: by qgez77 with SMTP id z77so94474590qge.1
	for <qemu-devel@nongnu.org>; Fri, 02 Oct 2015 06:38:03 -0700 (PDT)
Date: Fri, 2 Oct 2015 09:38:01 -0400
From: Kevin O'Connor <kevin@koconnor.net>
Message-ID: <20151002133801.GA16190@morn.lan>
References: <1443701677-13629-1-git-send-email-markmb@redhat.com>
	<1443701819-13855-1-git-send-email-markmb@redhat.com>
	<1443701819-13855-7-git-send-email-markmb@redhat.com>
	<560D5057.6010308@redhat.com> <20151001160242.GA7766@morn.lan>
	<1443773786.14636.12.camel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1443773786.14636.12.camel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 6/7] Make the kernel image in the fw_cfg
 DMA interface bootable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Drew <drjones@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, "Gabriel L. Somlo" <somlo@cmu.edu>, qemu-devel@nongnu.org, Marc =?iso-8859-1?Q?Mar=ED?= <markmb@redhat.com>, Laszlo Ersek <lersek@redhat.com>

On Fri, Oct 02, 2015 at 10:16:26AM +0200, Gerd Hoffmann wrote:
>   Hi,
> 
> > That's fine with me.  Marc - I think qemu_vmlinux_setup() in SeaBIOS
> > with the following would work:
> > 
> > void qemu_vmlinux_setup(void)
> > {
> >     u32 kernel_size;
> >     qemu_cfg_read_entry(&kernel_size, QEMU_CFG_KERNEL_SIZE, sizeof(kernel_size));
> >     if (kernel_size)
> >         boot_add_qemu_vmlinux("QEMU Kernel image", 0);
> > }
> 
> It isn't that simple.  We also have support for multiboot kernels (using
> multiboot.bin option rom).  So when doing this you need to be prepared
> to find a multiboot kernel in fw_cfg.

Is there some way to detect if it's a multiboot kernel?  If so,
seabios can just fall back to using multiboot.bin.

-Kevin